Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear members if iam_binding doesn't find a binding #2481

Merged

Conversation

slevenick
Copy link
Contributor

Currently we don't delete the members in state if we don't find the role.

Fixes: hashicorp/terraform-provider-google#4686

Release Note Template for Downstream PRs (will be copied)

IAM binding now replaces members if they have been deleted outside of terraform. 

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 1c59431.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1272
depends: hashicorp/terraform-provider-google#4693

@slevenick slevenick changed the title Force clear members if iam_binding doesn't find a binding Clear members if iam_binding doesn't find a binding Oct 16, 2019
@slevenick slevenick requested a review from danawillow October 16, 2019 22:15
slevenick and others added 2 commits October 17, 2019 17:06
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit d76cd0d into GoogleCloudPlatform:master Oct 17, 2019
JanMa pushed a commit to JanMa/magic-modules that referenced this pull request Oct 25, 2019
JanMa added a commit to JanMa/magic-modules that referenced this pull request Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manually removed google_project_iam_binding is not detected and recreated
4 participants