Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cloud SCC Source resource #2167

Merged
merged 1 commit into from
Aug 14, 2019
Merged

Add Cloud SCC Source resource #2167

merged 1 commit into from
Aug 14, 2019

Conversation

rileykarson
Copy link
Member

@rileykarson rileykarson commented Aug 13, 2019 •
edited
Loading

Fixes hashicorp/terraform-provider-google#4252

Release Note for Downstream PRs (will be copied)

Add `google_scc_source` resource for managing Cloud Security Command Center sources in Terraform

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 8cd9e40bb7ed542d24db3128ba7636a7028f636e.

Pull request statuses

No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1033
depends: GoogleCloudPlatform/terraform-google-conversion#159
depends: hashicorp/terraform-provider-google#4236

@rileykarson rileykarson force-pushed the scc-source branch 2 times, most recently from 5062c60 to 1f0ead6 Compare August 13, 2019 21:38
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 1f0ead6.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 150724e.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, bf7798c.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@rileykarson rileykarson requested review from danawillow and megan07 and removed request for danawillow August 14, 2019 15:15
rileykarson
rileykarson commented Aug 14, 2019
View reviewed changes
products/securitycenter/terraform.yaml
# limitations under the License.

--- !ruby/object:Provider::Terraform::Config
legacy_name: scc
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This renaming matches the service name used throughout the product documentation ("Cloud SCC") and the gcloud command gcloud scc.

I think it'll match user expectations better than security_center, but if you feel otherwise let me know!

megan07
megan07 approved these changes Aug 14, 2019
View reviewed changes
Copy link
Contributor

@megan07 megan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@modular-magician modular-magician merged commit 0708f96 into GoogleCloudPlatform:master Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@megan07 megan07 megan07 approved these changes

Assignees
No one assigned
Labels
automerged cla: yes downstream-generated terraform-google-conversion terraform-provider-google terraform-provider-google-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cloud Security Command Center (SCC) Source resource
4 participants
@rileykarson @modular-magician @megan07 @googlebot