Terraform Pub/Sub fix, do not send name on topic/subscription creation. #1896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in Ansible. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
rileykarson
approved these changes
Jun 10, 2019
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
modular-magician
force-pushed
the
pubsub-noname
branch
from
48c6e30 to
dc797e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strictly speaking the body of
projects.topics.createandprojects.subscriptions.createshouldn't include the resource name, as this is only a path parameter. Including them seems to be harmless in the common case, but causes problems when the topic/subscription is within a VPC Service Controls perimeter.