Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a default to Cloud Functions runtime #1747

Merged
merged 2 commits into from
May 9, 2019

Conversation

rileykarson
Copy link
Member

Fixes an issue where the Cloud Functions API now requires a runtime to be explicitly defined.

All existing provider versions are affected;

  • 0.X, 1.X series providers have no workaround. Creation of new Cloud Functions is immediately broken.

  • 2.X series providers up to 2.6.0 can work around the change by specifying a runtime.

This is a mostly-safe transition, to the point that we can be comfortable including this in a bugfix release.

Prior to today, the API has defaulted to nodejs6 as the runtime for Cloud Functions. That has been exposed in the runtime variable in the API response, so all existing functions will have it set in state. They will see no diff. Users who explicitly defined a runtime are unaffected.

There is one exception- if users have defined a function in Terraform without specifying runtime and then modified the function out of band (or defined a runtime then removed it from config, due to how Computed works) they will see a diff. That said, it will be caught at plan time and we will highlight it in the changelog so anyone running Terraform in CI will be warned.


[all]

[terraform]

[terraform-beta]

[ansible]

[inspec]

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 6d89632.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#697
depends: hashicorp/terraform-provider-google#3605

rileykarson and others added 2 commits May 9, 2019 22:57
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 7eea62a into GoogleCloudPlatform:master May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants