Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just don't set remove_node_pool on import #1471

Merged

Conversation

emilymye
Copy link
Contributor

@emilymye emilymye commented Mar 4, 2019

Related to hashicorp/terraform-provider-google#3146 - revert the import change, but keep the change that makes sure update doesn't fail if set to true and it's already deleted.


[all]

[terraform]

Just don't set remove_node_pool on import

[terraform-beta]

Just don't set remove_node_pool on import

[ansible]

[inspec]

@emilymye emilymye force-pushed the cluster_node_pool_update branch from 7e5d6e0 to 8a48485 Compare March 4, 2019 20:31
@emilymye emilymye requested a review from rileykarson March 4, 2019 20:35
@emilymye emilymye force-pushed the cluster_node_pool_update branch from 8a48485 to 0462c78 Compare March 4, 2019 21:39
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 0462c78842e3471d90898971cb6e677d97b58658.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#495
depends: hashicorp/terraform-provider-google#3180

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 3f8daa9.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@emilymye emilymye force-pushed the cluster_node_pool_update branch from b868e02 to 9f9a2c9 Compare March 5, 2019 00:34
@emilymye emilymye force-pushed the cluster_node_pool_update branch from 9f9a2c9 to 0f32e20 Compare March 5, 2019 01:32
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 0f32e20.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit aa07fe3 into GoogleCloudPlatform:master Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants