Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make colab runtime startable/stoppable #12904

Merged
merged 26 commits into from
Feb 3, 2025

Conversation

bcreddy-gcp
Copy link
Contributor

@bcreddy-gcp bcreddy-gcp commented Jan 29, 2025

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

colab: made `google_colab_runtime` startable/stoppable.

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from hao-nan-li January 29, 2025 06:05
@bcreddy-gcp bcreddy-gcp marked this pull request as draft January 29, 2025 06:05
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 175 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 175 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 22 insertions(+))
Open in Cloud Shell: Diff ( 5 files changed, 134 insertions(+))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 175 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 175 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 22 insertions(+))
Open in Cloud Shell: Diff ( 5 files changed, 134 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 9
Passed tests: 8
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • colab

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccColabRuntime_colabRuntimeStoppedExample

Get to know how VCR tests work

1 similar comment
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 9
Passed tests: 8
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • colab

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccColabRuntime_colabRuntimeStoppedExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccColabRuntime_colabRuntimeStoppedExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccColabRuntime_colabRuntimeStoppedExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 453 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 5 files changed, 453 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 22 insertions(+))
Open in Cloud Shell: Diff ( 5 files changed, 134 insertions(+))

@bcreddy-gcp bcreddy-gcp changed the title Make colab runtime startable/stoppable/upgradable Make colab runtime startable/stoppable Jan 30, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 474 insertions(+), 66 deletions(-))
google-beta provider: Diff ( 6 files changed, 474 insertions(+), 66 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 22 insertions(+))
Open in Cloud Shell: Diff ( 5 files changed, 134 insertions(+))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 474 insertions(+), 66 deletions(-))
google-beta provider: Diff ( 6 files changed, 474 insertions(+), 66 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 22 insertions(+))
Open in Cloud Shell: Diff ( 5 files changed, 134 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 13
Passed tests: 13
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • colab

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 13
Passed tests: 13
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • colab

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 473 insertions(+), 65 deletions(-))
google-beta provider: Diff ( 5 files changed, 473 insertions(+), 65 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 22 insertions(+))
Open in Cloud Shell: Diff ( 5 files changed, 134 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 13
Passed tests: 13
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • colab

🟢 All tests passed!

View the build log

Copy link
Contributor

@hao-nan-li hao-nan-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you briefly explain what does this change intend to do?

Is the colab runtime not startable even if the resource was created before?

@bcreddy-gcp
Copy link
Contributor Author

Colab runtime is always created in the "RUNNING" state. This change is to start/stop the runtime.

@hao-nan-li
Copy link
Contributor

Could you also update the release-note based on the release-note format?

@github-actions github-actions bot requested a review from hao-nan-li February 3, 2025 18:19
@bcreddy-gcp
Copy link
Contributor Author

Updated the release notes. PTAL.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 474 insertions(+), 65 deletions(-))
google-beta provider: Diff ( 5 files changed, 474 insertions(+), 65 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 22 insertions(+))
Open in Cloud Shell: Diff ( 5 files changed, 134 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 13
Passed tests: 13
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • colab

🟢 All tests passed!

View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants