Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google secure_source_manager hook resource #12525

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ericzzzzzzz
Copy link

@ericzzzzzzz ericzzzzzzz commented Dec 9, 2024

Add secure_source_manager hook resource and test

Release Note Template for Downstream PRs (will be copied)

`google_secure_source_manager_hook`

@ericzzzzzzz ericzzzzzzz force-pushed the add-google_secure_source_manager_hook-resource branch 2 times, most recently from 5570673 to 40e16b1 Compare December 9, 2024 18:48
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1261 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1261 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 128 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 255 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_secure_source_manager_hook (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_secure_source_manager_hook" "primary" {
  disabled = # value needed
  etag     = # value needed
}

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1261 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1261 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 128 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 255 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_secure_source_manager_hook (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_secure_source_manager_hook" "primary" {
  disabled = # value needed
  etag     = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 16
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages
  • securesourcemanager

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSecureSourceManagerHook_secureSourceManagerHookBasicExample
  • TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample
  • TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample_update
  • TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

1 similar comment
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 16
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages
  • securesourcemanager

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSecureSourceManagerHook_secureSourceManagerHookBasicExample
  • TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample
  • TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample_update
  • TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

@ericzzzzzzz ericzzzzzzz force-pushed the add-google_secure_source_manager_hook-resource branch from 40e16b1 to 9765a9e Compare December 9, 2024 18:58
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1261 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1261 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 128 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 255 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_secure_source_manager_hook (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_secure_source_manager_hook" "primary" {
  disabled = # value needed
  etag     = # value needed
}

@ericzzzzzzz ericzzzzzzz force-pushed the add-google_secure_source_manager_hook-resource branch from 9765a9e to 248911d Compare December 9, 2024 19:01
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 16
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages
  • securesourcemanager

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSecureSourceManagerHook_secureSourceManagerHookBasicExample
  • TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample
  • TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample_update
  • TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1261 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1261 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 128 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 255 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_secure_source_manager_hook (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_secure_source_manager_hook" "primary" {
  disabled = # value needed
  etag     = # value needed
}

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1261 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1261 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 128 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 255 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_secure_source_manager_hook (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_secure_source_manager_hook" "primary" {
  disabled = # value needed
  etag     = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 16
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages
  • securesourcemanager

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSecureSourceManagerHook_secureSourceManagerHookBasicExample
  • TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample
  • TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample_update
  • TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

1 similar comment
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 16
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages
  • securesourcemanager

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSecureSourceManagerHook_secureSourceManagerHookBasicExample
  • TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample
  • TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample_update
  • TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccSecureSourceManagerHook_secureSourceManagerHookBasicExample [Error message] [Debug log]
TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample [Error message] [Debug log]
TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample_update [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccSecureSourceManagerHook_secureSourceManagerHookBasicExample [Error message] [Debug log]
TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample [Error message] [Debug log]
TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample_update [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccSecureSourceManagerHook_secureSourceManagerHookBasicExample [Error message] [Debug log]
TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample [Error message] [Debug log]
TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample_update [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccSecureSourceManagerHook_secureSourceManagerHookBasicExample [Error message] [Debug log]
TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample [Error message] [Debug log]
TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample_update [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccSecureSourceManagerHook_secureSourceManagerHookBasicExample [Error message] [Debug log]
TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample [Error message] [Debug log]
TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample_update [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@ericzzzzzzz ericzzzzzzz force-pushed the add-google_secure_source_manager_hook-resource branch from 248911d to 92928e3 Compare December 9, 2024 20:18
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1265 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1265 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 128 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 257 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_secure_source_manager_hook (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_secure_source_manager_hook" "primary" {
  etag = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 16
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages
  • securesourcemanager

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSecureSourceManagerHook_secureSourceManagerHookBasicExample
  • TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample
  • TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample_update
  • TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccSecureSourceManagerHook_secureSourceManagerHookBasicExample [Error message] [Debug log]
TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample [Error message] [Debug log]
TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample_update [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1265 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1265 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 128 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 257 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_secure_source_manager_hook (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_secure_source_manager_hook" "primary" {
  etag = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 16
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages
  • securesourcemanager

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSecureSourceManagerHook_secureSourceManagerHookBasicExample
  • TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample
  • TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample_update
  • TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccSecureSourceManagerHook_secureSourceManagerHookBasicExample [Error message] [Debug log]
TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample [Error message] [Debug log]
TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample_update [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@ericzzzzzzz ericzzzzzzz force-pushed the add-google_secure_source_manager_hook-resource branch from bebf3b3 to 66da378 Compare December 16, 2024 18:19
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1265 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1265 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 128 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 257 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_secure_source_manager_hook (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_secure_source_manager_hook" "primary" {
  etag = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 16
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages
  • securesourcemanager

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSecureSourceManagerHook_secureSourceManagerHookBasicExample
  • TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample
  • TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample_update
  • TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1269 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1269 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 128 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 259 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_secure_source_manager_hook (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_secure_source_manager_hook" "primary" {
  etag = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 17
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • securesourcemanager

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSecureSourceManagerHook_secureSourceManagerHookBasicExample
  • TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample
  • TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccSecureSourceManagerHook_secureSourceManagerHookBasicExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample [Error message] [Debug log]
TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1272 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1272 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 128 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 259 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_secure_source_manager_hook (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_secure_source_manager_hook" "primary" {
  etag = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 18
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • securesourcemanager

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample
  • TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample [Error message] [Debug log]
TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@ericzzzzzzz ericzzzzzzz force-pushed the add-google_secure_source_manager_hook-resource branch from ffbfef8 to 33920ac Compare January 13, 2025 18:03
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1272 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1272 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 128 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 259 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_secure_source_manager_hook (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_secure_source_manager_hook" "primary" {
  etag = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 18
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • securesourcemanager

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample
  • TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample [Error message] [Debug log]
TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1272 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1272 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 128 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 259 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_secure_source_manager_hook (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_secure_source_manager_hook" "primary" {
  etag = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 18
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • securesourcemanager

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample
  • TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample [Error message] [Debug log]
TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1272 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1272 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 128 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 259 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_secure_source_manager_hook (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_secure_source_manager_hook" "primary" {
  etag = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 18
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • securesourcemanager

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample
  • TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample [Error message] [Debug log]
TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1272 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1272 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 128 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 259 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_secure_source_manager_hook (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_secure_source_manager_hook" "primary" {
  etag = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 18
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • securesourcemanager

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample
  • TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1288 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1288 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 128 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 259 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_secure_source_manager_hook (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_secure_source_manager_hook" "primary" {
  etag = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 19
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • securesourcemanager

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccSecureSourceManagerHook_secureSourceManagerHookWithFieldsExample_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@ericzzzzzzz ericzzzzzzz force-pushed the add-google_secure_source_manager_hook-resource branch from e36fd9e to c29d02d Compare January 22, 2025 20:02
@ericzzzzzzz ericzzzzzzz marked this pull request as ready for review January 22, 2025 20:03
@github-actions github-actions bot requested a review from melinath January 22, 2025 20:03
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1288 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1288 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 128 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 259 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_secure_source_manager_hook (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_secure_source_manager_hook" "primary" {
  etag = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 20
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • securesourcemanager

🟢 All tests passed!

View the build log

@ericzzzzzzz ericzzzzzzz marked this pull request as draft January 22, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants