This repository has been archived by the owner on Aug 2, 2024. It is now read-only.
add verbosity option #429
Merged
add verbosity option #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #429 +/- ##
============================================
- Coverage 59.50% 59.47% -0.03%
Complexity 120 120
============================================
Files 32 32
Lines 642 644 +2
Branches 50 50
============================================
+ Hits 382 383 +1
- Misses 244 245 +1
Partials 16 16
Continue to review full report at Codecov.
|
chanseokoh
reviewed
Sep 10, 2020
| @@ -42,6 +42,9 @@ | |||
| @Parameter(property = "serviceAccountKeyFile", required = false) | |||
| private File serviceAccountKeyFile; | |||
|
|
|||
| /** Optional parameter to configure the gcloud logging verbosity level. */ | |||
| @Parameter private String verbosity; | |||
There was a problem hiding this comment.
Is it unnecessary to have
@Parameter(property = "verbosity", required = false)
like for the serviceAccountKeyFile field?
There was a problem hiding this comment.
property is for the command line option -Dverbosity=info or something, which I'm hesitant to add, maybe it could be gcloud.verbosity or something? verbosity seems like it could clash with a bunch of things
There was a problem hiding this comment.
I will add gcloud.verbosity
chanseokoh
approved these changes
Sep 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.