Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for same-site prerendering with Speculation Rules API #258
Add support for same-site prerendering with Speculation Rules API #258
Changes from 14 commits
9551dd1
5b1186f
96d1de8
6314b81
82e2a86
94508f2
0134735
d91867c
50fc351
5bca8ef
1c183cd
baeb743
8d54fe0
54eea9b
a777f4e
0b69e2e
334d3f5
42cae5a
8757882
0443c72
bb371fc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not clear why this is assigning to the
conn
parameter. Did you mean to set a default on line 201? Or just remove theconn
parameter altogether? Or doconn || navigator.connection
?I guess this was already buggy...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same problem with assigning to a parameter here.