Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(layout-shift-elements): aggregate all remaining elements #15593

Merged
merged 8 commits into from
Dec 8, 2023
Merged

core(layout-shift-elements): aggregate all remaining elements #15593

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6de3f3c
core(layout-shift-elements): aggregate all remaining elements
adamraine Nov 7, 2023
d4fc5a5
Merge branch 'main' into layout-shift-event-aggregate
adamraine Dec 7, 2023
da7b066
sample
adamraine Dec 7, 2023
2882980
unit
adamraine Dec 7, 2023
a2bf9a7
unit cleanup
adamraine Dec 7, 2023
cd40c14
15
adamraine Dec 7, 2023
fae4882
unit more
adamraine Dec 7, 2023
896dca7
5 -> 15
adamraine Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
sample
  • Loading branch information
@adamraine
adamraine committed Dec 7, 2023
commit da7b06695dd03c8f9dfc317ea236d5831c146ef4
6 changes: 5 additions & 1 deletion core/audits/metrics/cumulative-layout-shift.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,11 @@ class CumulativeLayoutShift extends Audit {
*/
static async audit(artifacts, context) {
const trace = artifacts.traces[Audit.DEFAULT_PASS];
const {cumulativeLayoutShift, ...rest} = await ComputedCLS.request(trace, context);

// impactByNodeId is unused but we don't want it on debug data
// eslint-disable-next-line no-unused-vars
const {cumulativeLayoutShift, impactByNodeId, ...rest} =
await ComputedCLS.request(trace, context);

/** @type {LH.Audit.Details.DebugData} */
const details = {
Expand Down