Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(runner): independent gather and audit functions #13569

Merged
merged 22 commits into from
Feb 3, 2022
Merged

core(runner): independent gather and audit functions #13569

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
627356d
core(runner): independent gather and audit functions
adamraine Jan 14, 2022
cd390a4
+ runner state
adamraine Jan 14, 2022
90e31dc
Revert "+ runner state"
adamraine Jan 18, 2022
f7f206d
rn
adamraine Jan 18, 2022
57935d6
shared opts
adamraine Jan 18, 2022
34c1a02
log msg
adamraine Jan 18, 2022
e631034
fix tests
adamraine Jan 18, 2022
2e01dfa
runner
adamraine Jan 18, 2022
b9fffaa
lr test
adamraine Jan 18, 2022
1f22fa6
sample
adamraine Jan 18, 2022
e868c3e
Merge branch 'master' into fr-defer-audit-runner
adamraine Jan 19, 2022
e54eabb
comments
adamraine Jan 20, 2022
e4a2ca2
Merge branch 'fr-defer-audit-runner' of github.com:GoogleChrome/light…
adamraine Jan 20, 2022
291ae9a
sync
adamraine Jan 20, 2022
69d5f98
new func
adamraine Jan 20, 2022
1757426
timings
adamraine Jan 20, 2022
ec46509
Merge branch 'master' into fr-defer-audit-runner
adamraine Jan 25, 2022
900f948
core(runner): store gather timing on artifacts (#13587)
adamraine Feb 1, 2022
7c0d9e2
Merge branch 'master' into fr-defer-audit-runner
adamraine Feb 1, 2022
1b05363
Merge branch 'master' into fr-defer-audit-runner
adamraine Feb 1, 2022
7eec630
tests: timing smoke test (#13614)
adamraine Feb 2, 2022
6c961ee
Merge branch 'master' into fr-defer-audit-runner
adamraine Feb 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
sample
  • Loading branch information
@adamraine
adamraine committed Jan 18, 2022
commit 1f22fa670f15cf940494d72aba1d4a71accda99f
8 changes: 7 additions & 1 deletion lighthouse-core/test/results/sample_v2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6870,7 +6870,13 @@
},
{
"startTime": 0,
"name": "lh:runner:run",
"name": "lh:runner:gather",
"duration": 100,
"entryType": "measure"
},
{
"startTime": 0,
"name": "lh:runner:audit",
"duration": 100,
"entryType": "measure"
},
Expand Down
3 changes: 2 additions & 1 deletion ...m-webtests/webtests/http/tests/devtools/lighthouse/lighthouse-successful-run-expected.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Loading…
Create config
Requiring gatherers
Requiring audits
Runner setup
Gather phase
Connecting to browser
Resetting state with about:blank
Navigating to about:blank
Expand Down Expand Up @@ -146,6 +146,7 @@ Running afterPass methods
Gathering: ServiceWorker
Disconnecting from browser...
Cleaning origin data
Audit phase
Analyzing and running audits...
Auditing: Uses HTTPS
Auditing: Registers a service worker that controls page and `start_url`
Expand Down