Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(object-alt): remove md syntax around "alt" #13517

Merged
merged 3 commits into from
Dec 20, 2021
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lighthouse-core/audits/accessibility/object-alt.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ const i18n = require('../../lib/i18n/i18n.js');

const UIStrings = {
/** Title of an accesibility audit that evaluates if all object elements have an alt HTML attribute that describes their contents. This title is descriptive of the successful state and is shown to users when no user action is required. */
title: '`<object>` elements have `[alt]` text',
title: '`<object>` elements have alt text',
/** Title of an accesibility audit that evaluates if all object elements have an alt HTML attribute that describes their contents. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */
failureTitle: '`<object>` elements do not have `[alt]` text',
failureTitle: '`<object>` elements do not have alt text',
/** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. 'Learn More' becomes link text to additional documentation. */
description: 'Screen readers cannot translate non-text content. Adding alt text to ' +
'`<object>` elements helps screen readers convey meaning to users. ' +
Expand Down
4 changes: 0 additions & 4 deletions lighthouse-core/scripts/i18n/collect-strings.js
Original file line number Diff line number Diff line change
Expand Up @@ -653,10 +653,6 @@ function resolveMessageCollisions(strings) {

try {
expect(collidingMessages).toEqual([
'$MARKDOWN_SNIPPET_0$ elements do not have $MARKDOWN_SNIPPET_1$ text',
'$MARKDOWN_SNIPPET_0$ elements do not have $MARKDOWN_SNIPPET_1$ text',
'$MARKDOWN_SNIPPET_0$ elements have $MARKDOWN_SNIPPET_1$ text',
'$MARKDOWN_SNIPPET_0$ elements have $MARKDOWN_SNIPPET_1$ text',
'ARIA $MARKDOWN_SNIPPET_0$ elements do not have accessible names.',
'ARIA $MARKDOWN_SNIPPET_0$ elements do not have accessible names.',
'ARIA $MARKDOWN_SNIPPET_0$ elements do not have accessible names.',
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/test/results/sample_v2.json
Original file line number Diff line number Diff line change
Expand Up @@ -4012,7 +4012,7 @@
},
"object-alt": {
"id": "object-alt",
"title": "`<object>` elements do not have `[alt]` text",
"title": "`<object>` elements do not have alt text",
"description": "Screen readers cannot translate non-text content. Adding alt text to `<object>` elements helps screen readers convey meaning to users. [Learn more](https://web.dev/object-alt/).",
"score": 0,
"scoreDisplayMode": "binary",
Expand Down
4 changes: 2 additions & 2 deletions shared/localization/locales/en-US.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions shared/localization/locales/en-XL.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ Auditing: Lists contain only `<li>` elements and script supporting elements (`<s
Auditing: List items (`<li>`) are contained within `<ul>` or `<ol>` parent elements
Auditing: The document does not use `<meta http-equiv="refresh">`
Auditing: `[user-scalable="no"]` is not used in the `<meta name="viewport">` element and the `[maximum-scale]` attribute is not less than 5.
Auditing: `<object>` elements have `[alt]` text
Auditing: `<object>` elements have alt text
Auditing: No element has a `[tabindex]` value greater than 0
Auditing: Cells in a `<table>` element that use the `[headers]` attribute refer to table cells within the same table.
Auditing: `<th>` elements and elements with `[role="columnheader"/"rowheader"]` have data cells they describe.
Expand Down