Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin):fixed paging with select box #427

Merged
merged 1 commit into from
May 24, 2021
Merged

fix(admin):fixed paging with select box #427

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion template/types/action/fieldfilter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"html/template"

"github.com/GoAdminGroup/go-admin/plugins/admin/modules/form"
"github.com/GoAdminGroup/go-admin/plugins/admin/modules/parameter"
"github.com/GoAdminGroup/go-admin/template/types"
)

Expand Down Expand Up @@ -36,7 +37,9 @@ $("select` + jump.BtnId + `").on("select2:select",function(e){
let has = false;
for (let i = 0; i < vars.length; i++) {
pair = vars[i].split("=");
if (pair[0] === field) {
if (pair[0] == "` + parameter.Page + `") {
Copy link
Collaborator

@chenhg5 chenhg5 May 23, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr👍👍. Maybe we can add some comments here which will help the developer read the code easily.

continue
} else if (pair[0] === field) {
has = true
params += field + "=" + value + "&"
} else if (pair[0] !== "` + form.NoAnimationKey + `") {
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.