-
-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gix blame -L start,end
#1766
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for making blame
even better!
Besides my comments which are more like nits to let it appear less rushed, one change I really have to ask for: Changes to gix-blame
need to go into their own commit, and be prefixed with feat!:
to indicate a breaking change. A single test there probably would be a good idea (or necessity) as well.
The changes to the other two crates can be bundled as they logically are one (core
+ gitoxide
).
Thanks a lot!
Sure, no worries, and thank for letting me know! I’m not fully familiar with all the conventions yet, so always grateful to learn them. :-) |
f99eacf
to
1f67966
Compare
1f67966
to
1500c08
Compare
Thanks a lot for the fixes! Additionally, I have modified the second commits subject to not contain a |
This enables running blame for a portion of a file. This feature will be helful for debugging
gix blame
, in particular in the context of #1743.