-
-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more merge features #1661
Merged
more merge features #1661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Byron
force-pushed
the
merge
branch
4 times, most recently
from
November 15, 2024 17:37
9ac0a04
to
d4b718b
Compare
Byron
force-pushed
the
merge
branch
5 times, most recently
from
November 20, 2024 21:03
10ae556
to
665e548
Compare
They aim at making it possible to know if a conflict happened that was automatically resolved.
`gix-protocol` should support it one day, probably with a crate implementing the protocol, which is then used from the functionsin the crate. Ideally abstracting it fully.
Byron
force-pushed
the
merge
branch
6 times, most recently
from
November 23, 2024 20:29
29323b0
to
d803ff5
Compare
This makes it easier to change the stage of an entry.
This makes it easier to reason about.
This yields additional debugging information with details about detected conflicts.
This is the way Git acts, as it's either configured, or defaults to the value coming from the `diff.renames` configuration.
These changes will then be applicable to an index that is created from the written tree editor.
…::tree::Outcome::index_changed_after_applying_conflicts()`
10 tasks
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the last remaining features that are required to do all merging in GitButler with
gitoxide
.Follow-up of #1659.
Tasks
Resolution::CompleteAfterAutoResolution
and assure it's easy to learn about this kind of conflict when checking if there was an unresolved conflict or not.diff.renames
andmerge.renames
gix
Bring these changes to the downstream and make a release.
Shortcomings
Next PR
Possible Tasks
libgit2
also doesn't try it.textconv
with context, see this gist for details.GIT_DIR
set, others do.gix-command::Context
.Make blob-merge based conflict handling possible in the tree merge from- not needed for nowgix
at least.Research
record_conflicted_entries()
sets the index to match what was recorded.gitoxide
can checkout a tree as well (while keeping the index in memory).checkout()
by tree-id, with auto-updates to the index, in-memory.Archive
Everything is about MergeORT.
ability to re-use object caches of a repo that has seen the base-tree already, but overall, who knows*
-X ours
for instance don't affect tree-related auto-resolutions, just the ones related to content. This could be implemented when there is demand though.merge-ORT
cannot properly handle renames within renamed directories, ending up with the source of the subdir-rename still present.git2::MergeOptions
.