fix(OpenGeode): update to new warnings #133

BotellaA · 2024-09-11T14:24:51Z

No description provided.

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 25 out of 34. Check the log or trigger a new build to see more.

github-actions · 2024-09-11T14:27:21Z

include/geode/geosciences/explicit/mixin/core/fault.hpp


+    public:


warning: redundant access specifier has the same accessibility as the previous access specifier [readability-redundant-access-specifiers]

Suggested change

public:

Additional context

include/geode/geosciences/explicit/mixin/core/fault.hpp:51: previously declared here

public: ^

github-actions · 2024-09-11T14:27:21Z

include/geode/geosciences/explicit/mixin/core/fault_block.hpp

        {
            return { this->component_type_static(), this->id() };
        };

-        FaultBlock( FaultBlocksKey ) : FaultBlock(){};
+    public:


warning: redundant access specifier has the same accessibility as the previous access specifier [readability-redundant-access-specifiers]

Suggested change

public:

Additional context

include/geode/geosciences/explicit/mixin/core/fault_block.hpp:51: previously declared here

public: ^

github-actions · 2024-09-11T14:27:21Z

include/geode/geosciences/explicit/mixin/core/fault_block.hpp

        {
            return { this->component_type_static(), this->id() };
        };

-        FaultBlock( FaultBlocksKey ) : FaultBlock(){};
+    public:
+        FaultBlock( FaultBlocksKey ) : FaultBlock() {};


warning: all parameters should be named in a function [readability-named-parameter]

Suggested change

FaultBlock( FaultBlocksKey ) : FaultBlock() {};

FaultBlock( FaultBlocksKey /*unused*/) : FaultBlock() {};

github-actions · 2024-09-11T14:27:22Z

include/geode/geosciences/explicit/mixin/core/horizon.hpp


+    public:


warning: redundant access specifier has the same accessibility as the previous access specifier [readability-redundant-access-specifiers]

Suggested change

public:

Additional context

include/geode/geosciences/explicit/mixin/core/horizon.hpp:51: previously declared here

public: ^

github-actions · 2024-09-11T14:27:22Z

include/geode/geosciences/explicit/representation/io/cross_section_input.hpp

@@ -44,8 +44,8 @@ namespace geode
     * The adequate loader is called depending on the filename extension.
     * @param[in] filename Path to the file to load.
     */
-    CrossSection opengeode_geosciences_explicit_api load_cross_section(
-        std::string_view filename );
+    [[nodiscard]] CrossSection opengeode_geosciences_explicit_api


warning: variable 'opengeode_geosciences_explicit_api' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]

[[nodiscard]] CrossSection opengeode_geosciences_explicit_api ^

github-actions · 2024-09-11T14:27:24Z

include/geode/geosciences/implicit/representation/io/implicit_cross_section_input.hpp

@@ -59,11 +59,12 @@
        }
    };

-    ImplicitCrossSectionInput::MissingFiles opengeode_geosciences_implicit_api
+    [[nodiscard]] ImplicitCrossSectionInput::MissingFiles
+        opengeode_geosciences_implicit_api


warning: variable 'opengeode_geosciences_implicit_api' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]

opengeode_geosciences_implicit_api ^

github-actions · 2024-09-11T14:27:24Z

include/geode/geosciences/implicit/representation/io/implicit_cross_section_input.hpp

        check_implicit_cross_section_missing_files( std::string_view filename );

-    bool opengeode_geosciences_implicit_api is_implicit_cross_section_loadable(
-        std::string_view filename );
+    [[nodiscard]] bool opengeode_geosciences_implicit_api


warning: variable 'opengeode_geosciences_implicit_api' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]

[[nodiscard]] bool opengeode_geosciences_implicit_api ^

github-actions · 2024-09-11T14:27:24Z

include/geode/geosciences/implicit/representation/io/implicit_cross_section_output.hpp

            : Output< ImplicitCrossSection >{ filename }
        {
        }
    };

-    bool opengeode_geosciences_implicit_api is_implicit_cross_section_saveable(
-        const ImplicitCrossSection& section, std::string_view filename );
+    [[nodiscard]] bool opengeode_geosciences_implicit_api


warning: variable 'opengeode_geosciences_implicit_api' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]

[[nodiscard]] bool opengeode_geosciences_implicit_api ^

github-actions · 2024-09-11T14:27:24Z

include/geode/geosciences/implicit/representation/io/implicit_structural_model_input.hpp

@@ -42,7 +42,7 @@ namespace geode
     * The adequate loader is called depending on the filename extension.
     * @param[in] filename Path to the file to load.
     */
-    ImplicitStructuralModel opengeode_geosciences_implicit_api
+    [[nodiscard]] ImplicitStructuralModel opengeode_geosciences_implicit_api


warning: variable 'opengeode_geosciences_implicit_api' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]

[[nodiscard]] ImplicitStructuralModel opengeode_geosciences_implicit_api ^

github-actions · 2024-09-11T14:27:24Z

include/geode/geosciences/implicit/representation/io/implicit_structural_model_input.hpp

        opengeode_geosciences_implicit_api
        check_implicit_structural_model_missing_files(
            std::string_view filename );

-    bool opengeode_geosciences_implicit_api
+    [[nodiscard]] bool opengeode_geosciences_implicit_api


warning: variable 'opengeode_geosciences_implicit_api' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]

[[nodiscard]] bool opengeode_geosciences_implicit_api ^

github-actions

clang-tidy made some suggestions

github-actions · 2024-09-20T12:31:24Z

include/geode/geosciences/implicit/representation/io/implicit_structural_model_output.hpp

            : Output< ImplicitStructuralModel >{ filename }
        {
        }
    };

-    bool opengeode_geosciences_implicit_api
+    [[nodiscard]] bool opengeode_geosciences_implicit_api


warning: variable 'opengeode_geosciences_implicit_api' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]

[[nodiscard]] bool opengeode_geosciences_implicit_api ^

github-actions · 2024-09-20T12:31:24Z

include/geode/geosciences/implicit/representation/io/stratigraphic_model_input.hpp

@@ -42,7 +42,7 @@ namespace geode
     * The adequate loader is called depending on the filename extension.
     * @param[in] filename Path to the file to load.
     */
-    StratigraphicModel opengeode_geosciences_implicit_api
+    [[nodiscard]] StratigraphicModel opengeode_geosciences_implicit_api


warning: variable 'opengeode_geosciences_implicit_api' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]

[[nodiscard]] StratigraphicModel opengeode_geosciences_implicit_api ^

github-actions · 2024-09-20T12:31:24Z

include/geode/geosciences/implicit/representation/io/stratigraphic_model_input.hpp

@@ -59,11 +59,12 @@
        }
    };

-    StratigraphicModelInput::MissingFiles opengeode_geosciences_implicit_api
+    [[nodiscard]] StratigraphicModelInput::MissingFiles
+        opengeode_geosciences_implicit_api


warning: variable 'opengeode_geosciences_implicit_api' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]

opengeode_geosciences_implicit_api ^

github-actions · 2024-09-20T12:31:24Z

include/geode/geosciences/implicit/representation/io/stratigraphic_model_input.hpp

        check_stratigraphic_model_missing_files( std::string_view filename );

-    bool opengeode_geosciences_implicit_api is_stratigraphic_model_loadable(
-        std::string_view filename );
+    [[nodiscard]] bool opengeode_geosciences_implicit_api


warning: variable 'opengeode_geosciences_implicit_api' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]

[[nodiscard]] bool opengeode_geosciences_implicit_api ^

github-actions · 2024-09-20T12:31:24Z

include/geode/geosciences/implicit/representation/io/stratigraphic_model_output.hpp

-    bool opengeode_geosciences_implicit_api is_stratigraphic_model_saveable(
-        const StratigraphicModel& stratigraphic_model,
-        std::string_view filename );
+    [[nodiscard]] bool opengeode_geosciences_implicit_api


warning: variable 'opengeode_geosciences_implicit_api' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]

[[nodiscard]] bool opengeode_geosciences_implicit_api ^

github-actions · 2024-09-20T12:31:24Z

include/geode/geosciences/implicit/representation/io/stratigraphic_section_input.hpp

@@ -42,7 +42,7 @@ namespace geode
     * The adequate loader is called depending on the filename extension.
     * @param[in] filename Path to the file to load.
     */
-    StratigraphicSection opengeode_geosciences_implicit_api
+    [[nodiscard]] StratigraphicSection opengeode_geosciences_implicit_api


warning: variable 'opengeode_geosciences_implicit_api' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]

[[nodiscard]] StratigraphicSection opengeode_geosciences_implicit_api ^

github-actions · 2024-09-20T12:31:25Z

include/geode/geosciences/implicit/representation/io/stratigraphic_section_input.hpp

@@ -59,11 +59,12 @@
        }
    };

-    StratigraphicSectionInput::MissingFiles opengeode_geosciences_implicit_api
+    [[nodiscard]] StratigraphicSectionInput::MissingFiles
+        opengeode_geosciences_implicit_api


warning: variable 'opengeode_geosciences_implicit_api' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]

opengeode_geosciences_implicit_api ^

github-actions · 2024-09-20T12:31:25Z

include/geode/geosciences/implicit/representation/io/stratigraphic_section_input.hpp

        check_stratigraphic_section_missing_files( std::string_view filename );

-    bool opengeode_geosciences_implicit_api is_stratigraphic_section_loadable(
-        std::string_view filename );
+    [[nodiscard]] bool opengeode_geosciences_implicit_api


warning: variable 'opengeode_geosciences_implicit_api' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]

[[nodiscard]] bool opengeode_geosciences_implicit_api ^

github-actions · 2024-09-20T12:31:25Z

include/geode/geosciences/implicit/representation/io/stratigraphic_section_output.hpp

-    bool opengeode_geosciences_implicit_api is_stratigraphic_section_saveable(
-        const StratigraphicSection& stratigraphic_section,
-        std::string_view filename );
+    [[nodiscard]] bool opengeode_geosciences_implicit_api


warning: variable 'opengeode_geosciences_implicit_api' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]

[[nodiscard]] bool opengeode_geosciences_implicit_api ^

panquez · 2024-09-23T08:48:01Z

🎉 This PR is included in version 8.0.2-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

panquez · 2024-09-24T00:32:13Z

🎉 This PR is included in version 8.0.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

fix(OpenGeode): update to new warnings

a795600

BotellaA requested review from MelchiorSchuh and BenPinet September 11, 2024 14:24

Apply prepare changes

19a6faa

github-actions bot reviewed Sep 11, 2024

View reviewed changes

BotellaA requested a review from panquez September 20, 2024 11:18

github-actions bot reviewed Sep 20, 2024

View reviewed changes

Apply prepare changes

371580f

BotellaA force-pushed the fix/nodiscard branch from a3a477c to 371580f Compare September 20, 2024 12:33

panquez approved these changes Sep 20, 2024

View reviewed changes

MelchiorSchuh merged commit f4b30fd into next Sep 23, 2024
18 checks passed

MelchiorSchuh deleted the fix/nodiscard branch September 23, 2024 08:29

panquez added the released on @next label Sep 23, 2024

panquez added the released label Sep 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(OpenGeode): update to new warnings #133

fix(OpenGeode): update to new warnings #133

BotellaA commented Sep 11, 2024

github-actions bot left a comment

github-actions bot Sep 11, 2024

github-actions bot Sep 11, 2024

github-actions bot Sep 11, 2024

github-actions bot Sep 11, 2024

github-actions bot Sep 11, 2024

github-actions bot Sep 11, 2024

github-actions bot Sep 11, 2024

github-actions bot Sep 11, 2024

github-actions bot Sep 11, 2024

github-actions bot Sep 11, 2024

github-actions bot left a comment

github-actions bot Sep 20, 2024

github-actions bot Sep 20, 2024

github-actions bot Sep 20, 2024

github-actions bot Sep 20, 2024

github-actions bot Sep 20, 2024

github-actions bot Sep 20, 2024

github-actions bot Sep 20, 2024

github-actions bot Sep 20, 2024

github-actions bot Sep 20, 2024

panquez commented Sep 23, 2024

panquez commented Sep 24, 2024

	FaultBlock( FaultBlocksKey ) : FaultBlock() {};
	FaultBlock( FaultBlocksKey /unused/) : FaultBlock() {};

fix(OpenGeode): update to new warnings #133

fix(OpenGeode): update to new warnings #133

Conversation

BotellaA commented Sep 11, 2024

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Sep 11, 2024

Choose a reason for hiding this comment

github-actions bot Sep 11, 2024

Choose a reason for hiding this comment

github-actions bot Sep 11, 2024

Choose a reason for hiding this comment

github-actions bot Sep 11, 2024

Choose a reason for hiding this comment

github-actions bot Sep 11, 2024

Choose a reason for hiding this comment

github-actions bot Sep 11, 2024

Choose a reason for hiding this comment

github-actions bot Sep 11, 2024

Choose a reason for hiding this comment

github-actions bot Sep 11, 2024

Choose a reason for hiding this comment

github-actions bot Sep 11, 2024

Choose a reason for hiding this comment

github-actions bot Sep 11, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Sep 20, 2024

Choose a reason for hiding this comment

github-actions bot Sep 20, 2024

Choose a reason for hiding this comment

github-actions bot Sep 20, 2024

Choose a reason for hiding this comment

github-actions bot Sep 20, 2024

Choose a reason for hiding this comment

github-actions bot Sep 20, 2024

Choose a reason for hiding this comment

github-actions bot Sep 20, 2024

Choose a reason for hiding this comment

github-actions bot Sep 20, 2024

Choose a reason for hiding this comment

github-actions bot Sep 20, 2024

Choose a reason for hiding this comment

github-actions bot Sep 20, 2024

Choose a reason for hiding this comment

panquez commented Sep 23, 2024

panquez commented Sep 24, 2024