Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Headers): change extension convention from .h to .hpp #132

Merged
merged 3 commits into from
Jul 16, 2024
Merged

fix(Headers): change extension convention from .h to .hpp #132

merged 3 commits into from
Jul 16, 2024

Conversation

BotellaA
Copy link
Member

BREAKING CHANGE: rename all extensions from .h to.hpp

BotellaA and others added 2 commits July 16, 2024 12:23
github-actions[bot]
github-actions bot reviewed Jul 16, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 25 out of 98. Check the log or trigger a new build to see more.

bindings/python/src/explicit/geometry/crs.h
@@ -21,9 +21,9 @@
*
*/

#include <geode/basic/attribute_manager.h>
#include <geode/basic/attribute_manager.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'geode/basic/attribute_manager.hpp' file not found [clang-diagnostic-error]

#include <geode/basic/attribute_manager.hpp>
         ^

bindings/python/src/explicit/geometry/crs_helper.h
@@ -21,22 +21,22 @@
*
*/

#include <geode/basic/attribute_manager.h>
#include <geode/basic/attribute_manager.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'geode/basic/attribute_manager.hpp' file not found [clang-diagnostic-error]

#include <geode/basic/attribute_manager.hpp>
         ^

bindings/python/src/explicit/mixin/builder/fault_blocks_builder.h
@@ -21,9 +21,9 @@
*
*/

#include <geode/geosciences/explicit/mixin/core/fault_block.h>
#include <geode/geosciences/explicit/mixin/core/fault_block.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'geode/geosciences/explicit/mixin/core/fault_block.hpp' file not found [clang-diagnostic-error]

#include <geode/geosciences/explicit/mixin/core/fault_block.hpp>
         ^

bindings/python/src/explicit/mixin/builder/faults_builder.h
@@ -21,9 +21,9 @@
*
*/

#include <geode/geosciences/explicit/mixin/core/fault.h>
#include <geode/geosciences/explicit/mixin/core/fault.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'geode/geosciences/explicit/mixin/core/fault.hpp' file not found [clang-diagnostic-error]

#include <geode/geosciences/explicit/mixin/core/fault.hpp>
         ^

bindings/python/src/explicit/mixin/builder/horizons_builder.h
@@ -21,9 +21,9 @@
*
*/

#include <geode/geosciences/explicit/mixin/core/horizon.h>
#include <geode/geosciences/explicit/mixin/core/horizon.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'geode/geosciences/explicit/mixin/core/horizon.hpp' file not found [clang-diagnostic-error]

#include <geode/geosciences/explicit/mixin/core/horizon.hpp>
         ^

bindings/python/src/implicit/mixin/builder/stratigraphic_relationships_builder.h
@@ -21,7 +21,7 @@
*
*/

#include <geode/geosciences/implicit/mixin/builder/stratigraphic_relationships_builder.h>
#include <geode/geosciences/implicit/mixin/builder/stratigraphic_relationships_builder.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'geode/geosciences/implicit/mixin/builder/stratigraphic_relationships_builder.hpp' file not found [clang-diagnostic-error]

#include <geode/geosciences/implicit/mixin/builder/stratigraphic_relationships_builder.hpp>
         ^

bindings/python/src/implicit/mixin/core/stratigraphic_relationships.h
@@ -21,7 +21,7 @@
*
*/

#include <geode/geosciences/implicit/mixin/core/stratigraphic_relationships.h>
#include <geode/geosciences/implicit/mixin/core/stratigraphic_relationships.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'geode/geosciences/implicit/mixin/core/stratigraphic_relationships.hpp' file not found [clang-diagnostic-error]

#include <geode/geosciences/implicit/mixin/core/stratigraphic_relationships.hpp>
         ^

bindings/python/src/implicit/representation/builder/horizons_stack_builder.h
@@ -21,11 +21,11 @@
*
*/

#include <geode/geosciences/implicit/representation/builder/horizons_stack_builder.h>
#include <geode/geosciences/implicit/representation/builder/horizons_stack_builder.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'geode/geosciences/implicit/representation/builder/horizons_stack_builder.hpp' file not found [clang-diagnostic-error]

#include <geode/geosciences/implicit/representation/builder/horizons_stack_builder.hpp>
         ^

bindings/python/src/implicit/representation/builder/implicit_cross_section_builder.h
@@ -21,9 +21,9 @@
*
*/

#include <geode/geosciences/implicit/representation/builder/implicit_cross_section_builder.h>
#include <geode/geosciences/implicit/representation/builder/implicit_cross_section_builder.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'geode/geosciences/implicit/representation/builder/implicit_cross_section_builder.hpp' file not found [clang-diagnostic-error]

#include <geode/geosciences/implicit/representation/builder/implicit_cross_section_builder.hpp>
         ^

bindings/python/src/implicit/representation/builder/implicit_structural_model_builder.h
@@ -21,9 +21,9 @@
*
*/

#include <geode/geosciences/implicit/representation/builder/implicit_structural_model_builder.h>
#include <geode/geosciences/implicit/representation/builder/implicit_structural_model_builder.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'geode/geosciences/implicit/representation/builder/implicit_structural_model_builder.hpp' file not found [clang-diagnostic-error]

#include <geode/geosciences/implicit/representation/builder/implicit_structural_model_builder.hpp>
         ^

github-actions[bot]
github-actions bot reviewed Jul 16, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 25 out of 64. Check the log or trigger a new build to see more.

src/geode/geosciences/explicit/common.cpp
@@ -21,17 +21,17 @@
*
*/

#include <geode/basic/common.h>
#include <geode/basic/logger.h>
#include <geode/basic/common.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'geode/basic/common.hpp' file not found [clang-diagnostic-error]

#include <geode/basic/common.hpp>
         ^

src/geode/geosciences/explicit/geometry/geographic_coordinate_system.cpp
@@ -21,15 +21,15 @@
*
*/

#include <geode/geosciences/explicit/geometry/geographic_coordinate_system.h>
#include <geode/geosciences/explicit/geometry/geographic_coordinate_system.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'geode/geosciences/explicit/geometry/geographic_coordinate_system.hpp' file not found [clang-diagnostic-error]

 SOFTWARE.
                                ^

src/geode/geosciences/explicit/geometry/geographic_coordinate_system_helper.cpp
@@ -21,30 +21,30 @@
*
*/

#include <geode/geosciences/explicit/geometry/geographic_coordinate_system_helper.h>
#include <geode/geosciences/explicit/geometry/geographic_coordinate_system_helper.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'geode/geosciences/explicit/geometry/geographic_coordinate_system_helper.hpp' file not found [clang-diagnostic-error]

 SOFTWARE.
                                ^

src/geode/geosciences/explicit/mixin/builder/fault_blocks_builder.cpp
@@ -21,10 +21,10 @@
*
*/

#include <geode/geosciences/explicit/mixin/builder/fault_blocks_builder.h>
#include <geode/geosciences/explicit/mixin/builder/fault_blocks_builder.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'geode/geosciences/explicit/mixin/builder/fault_blocks_builder.hpp' file not found [clang-diagnostic-error]

#include <geode/geosciences/explicit/mixin/builder/fault_blocks_builder.hpp>
         ^

src/geode/geosciences/explicit/mixin/builder/faults_builder.cpp
@@ -21,10 +21,10 @@
*
*/

#include <geode/geosciences/explicit/mixin/builder/faults_builder.h>
#include <geode/geosciences/explicit/mixin/builder/faults_builder.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'geode/geosciences/explicit/mixin/builder/faults_builder.hpp' file not found [clang-diagnostic-error]

#include <geode/geosciences/explicit/mixin/builder/faults_builder.hpp>
         ^

src/geode/geosciences/explicit/representation/core/structural_model.cpp
@@ -21,12 +21,12 @@
*
*/

#include <geode/geosciences/explicit/representation/core/structural_model.h>
#include <geode/geosciences/explicit/representation/core/structural_model.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'geode/geosciences/explicit/representation/core/structural_model.hpp' file not found [clang-diagnostic-error]

#include <geode/geosciences/explicit/representation/core/structural_model.hpp>
         ^

src/geode/geosciences/explicit/representation/io/cross_section_input.cpp
@@ -21,19 +21,19 @@
*
*/

#include <geode/geosciences/explicit/representation/io/cross_section_input.h>
#include <geode/geosciences/explicit/representation/io/cross_section_input.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'geode/geosciences/explicit/representation/io/cross_section_input.hpp' file not found [clang-diagnostic-error]

#include <geode/geosciences/explicit/representation/io/cross_section_input.hpp>
         ^

src/geode/geosciences/explicit/representation/io/cross_section_output.cpp
@@ -21,19 +21,19 @@
*
*/

#include <geode/geosciences/explicit/representation/io/cross_section_output.h>
#include <geode/geosciences/explicit/representation/io/cross_section_output.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'geode/geosciences/explicit/representation/io/cross_section_output.hpp' file not found [clang-diagnostic-error]

#include <geode/geosciences/explicit/representation/io/cross_section_output.hpp>
         ^

src/geode/geosciences/explicit/representation/io/geode/geode_cross_section_input.cpp
@@ -21,26 +21,26 @@
*
*/

#include <geode/geosciences/explicit/representation/io/geode/geode_cross_section_input.h>
#include <geode/geosciences/explicit/representation/io/geode/geode_cross_section_input.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'geode/geosciences/explicit/representation/io/geode/geode_cross_section_input.hpp' file not found [clang-diagnostic-error]

#include <geode/geosciences/explicit/representation/io/geode/geode_cross_section_input.hpp>
         ^

src/geode/geosciences/explicit/representation/io/geode/geode_cross_section_output.cpp
@@ -21,7 +21,7 @@
*
*/

#include <geode/geosciences/explicit/representation/io/geode/geode_cross_section_output.h>
#include <geode/geosciences/explicit/representation/io/geode/geode_cross_section_output.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'geode/geosciences/explicit/representation/io/geode/geode_cross_section_output.hpp' file not found [clang-diagnostic-error]

#include <geode/geosciences/explicit/representation/io/geode/geode_cross_section_output.hpp>
         ^

@MelchiorSchuh MelchiorSchuh merged commit bd1d440 into v15 Jul 16, 2024
18 checks passed
@MelchiorSchuh MelchiorSchuh deleted the fix/headers branch July 16, 2024 16:02
@panquez
Copy link
Member

panquez commented Jul 16, 2024

🎉 This PR is included in version 8.0.0-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@panquez
Copy link
Member

panquez commented Jul 17, 2024

🎉 This PR is included in version 8.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
released on @next released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BotellaA @panquez @MelchiorSchuh