Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

other option select #354

Merged
merged 2 commits into from
Feb 28, 2025
Merged

other option select #354

merged 2 commits into from
Feb 28, 2025

Conversation

andyvo2004
Copy link
Contributor

@andyvo2004 andyvo2004 commented Feb 27, 2025

other option select

Issue Number(s): #344 .

What does this PR change and why?

  • Added new optional field "otherBreedDescription" to post model
  • If "Other" breed is selected when editing/creating a post, a description box to describe the breed appears
  • If a post has "Other" breed and there is an otherBreedDescription, it is displayed as "Other (otherBreedDescription)"
  • "Other" breed can be added to breed preferences/restrictions (does nothing?)

Checklist

  • Add an "Other" option to the breed type dropdown.
  • When "Other" is selected, display a text box labeled "Description" for admins to enter details.
  • Ensure the entered description is saved properly.

Testing

Tested creating and editing a post with the "Other" breed. Tested filtering posts with the "Other" breed.

Copy link

github-actions bot commented Feb 27, 2025

Coverage report for web

Caution

Test run failed

St.
Category Percentage Covered / Total
🔴 Statements 19.12% 265/1386
🔴 Branches 11.43% 48/420
🔴 Functions 7.79% 31/398
🔴 Lines 12.54% 148/1180

Test suite run failed

Failed tests: 0/23. Failed suites: 8/11.
  ● Test suite failed to run

    Your test suite must contain at least one test.

      at onResult (node_modules/@jest/core/build/TestScheduler.js:133:18)
      at node_modules/@jest/core/build/TestScheduler.js:254:19
      at node_modules/emittery/index.js:363:13
          at Array.map (<anonymous>)
      at Emittery.emit (node_modules/emittery/index.js:361:23)


  ● Test suite failed to run

    Your test suite must contain at least one test.

      at onResult (node_modules/@jest/core/build/TestScheduler.js:133:18)
      at node_modules/@jest/core/build/TestScheduler.js:254:19
      at node_modules/emittery/index.js:363:13
          at Array.map (<anonymous>)
      at Emittery.emit (node_modules/emittery/index.js:361:23)


  ● Test suite failed to run

    Your test suite must contain at least one test.

      at onResult (node_modules/@jest/core/build/TestScheduler.js:133:18)
      at node_modules/@jest/core/build/TestScheduler.js:254:19
      at node_modules/emittery/index.js:363:13
          at Array.map (<anonymous>)
      at Emittery.emit (node_modules/emittery/index.js:361:23)


  ● Test suite failed to run

    Your test suite must contain at least one test.

      at onResult (node_modules/@jest/core/build/TestScheduler.js:133:18)
      at node_modules/@jest/core/build/TestScheduler.js:254:19
      at node_modules/emittery/index.js:363:13
          at Array.map (<anonymous>)
      at Emittery.emit (node_modules/emittery/index.js:361:23)


  ● Test suite failed to run

    Your test suite must contain at least one test.

      at onResult (node_modules/@jest/core/build/TestScheduler.js:133:18)
      at node_modules/@jest/core/build/TestScheduler.js:254:19
      at node_modules/emittery/index.js:363:13
          at Array.map (<anonymous>)
      at Emittery.emit (node_modules/emittery/index.js:361:23)


  ● Test suite failed to run

    Your test suite must contain at least one test.

      at onResult (node_modules/@jest/core/build/TestScheduler.js:133:18)
      at node_modules/@jest/core/build/TestScheduler.js:254:19
      at node_modules/emittery/index.js:363:13
          at Array.map (<anonymous>)
      at Emittery.emit (node_modules/emittery/index.js:361:23)


  ● Test suite failed to run

    Your test suite must contain at least one test.

      at onResult (node_modules/@jest/core/build/TestScheduler.js:133:18)
      at node_modules/@jest/core/build/TestScheduler.js:254:19
      at node_modules/emittery/index.js:363:13
          at Array.map (<anonymous>)
      at Emittery.emit (node_modules/emittery/index.js:361:23)


  ● Test suite failed to run

    Returning a Promise from "describe" is not supported. Tests must be defined synchronously.

      17 |  * @group unit
      18 |  */
    > 19 | describe("[API] Account - Integration Test", async () => {
         | ^
      20 |   const context = await createContextInner();
      21 |   const caller = appRouter.createCaller(context);
      22 |

      at Object.describe (__tests__/pages/api/account/account.int.test.ts:19:1)

Report generated by 🧪jest coverage report action from 9dccb19

Copy link
Member

@SamratSahoo SamratSahoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SamratSahoo SamratSahoo merged commit 1ce458b into staging Feb 28, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants