-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
## Description The `bldd` opcode was not covered in the `Op::parse_opcode()` which resulted in `Unknown opcode: "bldd"` error. The remaining part of the `bldd` opcode integration chain is already implemented in #6254. ## Checklist - [x] I have linked to any relevant issues. - [ ] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] If my change requires substantial documentation changes, I have [requested support from the DevRel team](/~https://github.com/FuelLabs/devrel-requests/issues/new/choose) - [ ] I have added tests that prove my fix is effective or that my feature works. - [ ] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](/~https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers.
- Loading branch information
Showing
16 changed files
with
45 additions
and
29 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 0 additions & 8 deletions
8
test/src/e2e_vm_tests/test_programs/should_pass/ecall/ecall_basic/Forc.lock
This file was deleted.
Oops, something went wrong.
1 change: 0 additions & 1 deletion
1
test/src/e2e_vm_tests/test_programs/should_pass/ecall/ecall_basic/test.toml
This file was deleted.
Oops, something went wrong.
3 changes: 3 additions & 0 deletions
3
test/src/e2e_vm_tests/test_programs/should_pass/language/asm/instructions/bldd/Forc.lock
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
[[package]] | ||
name = "bldd" | ||
source = "member" |
6 changes: 6 additions & 0 deletions
6
test/src/e2e_vm_tests/test_programs/should_pass/language/asm/instructions/bldd/Forc.toml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
[project] | ||
authors = ["Fuel Labs <contact@fuel.sh>"] | ||
license = "Apache-2.0" | ||
name = "bldd" | ||
entry = "main.sw" | ||
implicit-std = false |
10 changes: 10 additions & 0 deletions
10
test/src/e2e_vm_tests/test_programs/should_pass/language/asm/instructions/bldd/src/main.sw
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
library; | ||
|
||
// Intentionally not using `b256::zero()` to avoid dependency to `core`. | ||
const B256_ZERO: b256 = 0x0000000000000000000000000000000000000000000000000000000000000000; | ||
|
||
pub fn main() { | ||
asm(r1: B256_ZERO, r2: B256_ZERO, r3: 42u64, r4: 21u64) { | ||
bldd r1 r2 r3 r4; | ||
} | ||
} |
1 change: 1 addition & 0 deletions
1
test/src/e2e_vm_tests/test_programs/should_pass/language/asm/instructions/bldd/test.toml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
category = "compile" |
3 changes: 3 additions & 0 deletions
3
test/src/e2e_vm_tests/test_programs/should_pass/language/asm/instructions/ecall/Forc.lock
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
[[package]] | ||
name = "ecall" | ||
source = "member" |
6 changes: 6 additions & 0 deletions
6
test/src/e2e_vm_tests/test_programs/should_pass/language/asm/instructions/ecall/Forc.toml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
[project] | ||
authors = ["Fuel Labs <contact@fuel.sh>"] | ||
license = "Apache-2.0" | ||
name = "ecall" | ||
entry = "main.sw" | ||
implicit-std = false |
4 changes: 2 additions & 2 deletions
4
...should_pass/ecall/ecall_basic/src/main.sw → ...nguage/asm/instructions/ecall/src/main.sw
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
script; | ||
library; | ||
|
||
fn main() { | ||
pub fn main() { | ||
asm(r1: 1u64, r2: 2u32, r3: 3u32, r4: 4u32) { | ||
ecal r1 r2 r3 r4; | ||
} | ||
|
1 change: 1 addition & 0 deletions
1
test/src/e2e_vm_tests/test_programs/should_pass/language/asm/instructions/ecall/test.toml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
category = "compile" |
14 changes: 7 additions & 7 deletions
14
.../language/asm_wqxx_instructions/Forc.lock → .../language/asm/instructions/wqxx/Forc.lock
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,13 @@ | ||
[[package]] | ||
name = "asm_wqxx_instructions" | ||
source = "member" | ||
dependencies = ["std"] | ||
|
||
[[package]] | ||
name = "core" | ||
source = "path+from-root-DEA77F133437397D" | ||
source = "path+from-root-6CA79EAC12B0D10A" | ||
|
||
[[package]] | ||
name = "std" | ||
source = "path+from-root-DEA77F133437397D" | ||
source = "path+from-root-6CA79EAC12B0D10A" | ||
dependencies = ["core"] | ||
|
||
[[package]] | ||
name = "wqxx" | ||
source = "member" | ||
dependencies = ["std"] |
5 changes: 2 additions & 3 deletions
5
...s/should_pass/ecall/ecall_basic/Forc.toml → .../language/asm/instructions/wqxx/Forc.toml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,8 @@ | ||
[project] | ||
name = "ecall_basic" | ||
authors = ["Fuel Labs <contact@fuel.sh>"] | ||
entry = "main.sw" | ||
implicit-std = false | ||
license = "Apache-2.0" | ||
name = "wqxx" | ||
|
||
[dependencies] | ||
core = { path = "../../../../../../../sway-lib-core" } | ||
std = { path = "../../../../../../reduced_std_libs/sway-lib-std-assert" } |
File renamed without changes.
File renamed without changes.
8 changes: 0 additions & 8 deletions
8
test/src/e2e_vm_tests/test_programs/should_pass/language/asm_wqxx_instructions/Forc.toml
This file was deleted.
Oops, something went wrong.