Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose dimensions parameter on Jina Embeddings #3969

Merged
merged 4 commits into from
Feb 3, 2025
+12 −2
Merged

Expose dimensions parameter on Jina Embeddings #3969

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c1a0a99
Expose dimensions parameter on Jina Embeddings
gururise Feb 2, 2025
80724df
fix linting issue
gururise Feb 3, 2025
f77d467
update description text to refer to dimensions
gururise Feb 3, 2025
cff2dcc
Update JinaAIEmbedding.ts
HenryHengZJ Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions packages/components/nodes/embeddings/JinaAIEmbedding/JinaAIEmbedding.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class JinaAIEmbedding_Embeddings implements INode {
constructor() {
this.label = 'Jina Embeddings'
this.name = 'jinaEmbeddings'
this.version = 1.0
this.version = 2.0
this.type = 'JinaEmbeddings'
this.icon = 'JinaAIEmbedding.svg'
this.category = 'Embeddings'
Expand All @@ -36,18 +36,28 @@ class JinaAIEmbedding_Embeddings implements INode {
type: 'string',
default: 'jina-embeddings-v2-base-en',
description: 'Refer to <a href="https://jina.ai/embeddings/" target="_blank">JinaAI documentation</a> for available models'
},
{
label: 'Dimensions',
name: 'modelDimensions',
type: 'number',
default: 1024,
description:
'Refer to <a href="https://jina.ai/embeddings/" target="_blank">JinaAI documentation</a> for available dimensions'
}
]
}

async init(nodeData: INodeData, _: string, options: ICommonObject): Promise<any> {
const modelName = nodeData.inputs?.modelName as string
const modelDimensions = nodeData.inputs?.modelDimensions as number
const credentialData = await getCredentialData(nodeData.credential ?? '', options)
const apiKey = getCredentialParam('jinaAIAPIKey', credentialData, nodeData)

const model = new JinaEmbeddings({
apiKey: apiKey,
model: modelName
model: modelName,
dimensions: modelDimensions
})

return model
Expand Down