Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 127 - ZonedDateTime in map keys can now be serialized with zone IDs #140

Merged
merged 1 commit into from
Oct 6, 2019
Merged

Fixes 127 - ZonedDateTime in map keys can now be serialized with zone IDs #140

merged 1 commit into from
Oct 6, 2019

Conversation

vetler
Copy link
Contributor

@vetler vetler commented Oct 3, 2019

Fixes #127 - ZonedDateTime in map keys can now be serialized with zone IDs

@cowtowncoder
Copy link
Member

Tough question on versioning. If we wanted to follow SemVer strictly, I think it should be included in 2.11 as there is behavioral change that might not be considered a bug (or it could be, hence ambiguity).
But 2.10.0 is just out -- if we had, say, 2.10.8, I'd say 2.11.

So: @kupci what do you think? I think I am ok with either 2.10.x or 2.11.

@cowtowncoder
Copy link
Member

So: I think patch itself is fine. And the only process thing here is that unless I have already asked and received CLA:

/~https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

that would be needed now (just once; no need to file for more contributions)

Thank you @vetler (Kiitos!) for the contribution; looking forward to merging it once we figure out right branch.

@kupci
Copy link
Member

kupci commented Oct 3, 2019

Given this requires the SerializationFeature.WRITE_DATES_WITH_ZONE_ID, which it is now working via @vetler 's fix, 2.10.x seems valid. In other words, this is a bug fix, so fits with

Bug fixes not affecting the API increment the patch version,

@cowtowncoder cowtowncoder added 2.10 active Issue being actively investigated and/or worked on labels Oct 3, 2019
@cowtowncoder
Copy link
Member

Ok, then we'll go with 2.10.

@vetler
Copy link
Contributor Author

vetler commented Oct 5, 2019

So: I think patch itself is fine. And the only process thing here is that unless I have already asked and received CLA:

/~https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

Where do I send it?

@vetler
Copy link
Contributor Author

vetler commented Oct 5, 2019

Build failure seems unrelated to changes?

@kupci
Copy link
Member

kupci commented Oct 5, 2019

Yes, seems unrelated to changes. I wonder if there are still Sonatype issues, as this looks like the same error as previously with the 2.10 release. There's a ticket with Sonatype opened already.

Checksum validation failed, expected 088cd9f174c370442f12200765610c3a98bfb69e but is ae19b6d3ac494b56b7134f261d60b6d7aa9e89d2 -> [Help 1]

@kupci kupci closed this Oct 5, 2019
@kupci kupci reopened this Oct 5, 2019
@kupci
Copy link
Member

kupci commented Oct 5, 2019

And here's where to send the CLA (copying from another PR):

Simplest way is usually to print, fill & sign, scan, email to info at fasterxml dot com.

@cowtowncoder
Copy link
Member

Sonatype fixed the problem with jackson-annotations, but it is possible to have a cached copy -- so it may make sense to rm either whole Maven cache, or at least:

rm ~/.m2/repository/com/fasterxml/jackson/core/jackson-annotations/

@vetler yes, send to info at fasterxml dot com

@cowtowncoder
Copy link
Member

CLA received, proceed with merging.

@cowtowncoder cowtowncoder merged commit 3fdf967 into FasterXML:master Oct 6, 2019
@cowtowncoder cowtowncoder added this to the 2.10.1 milestone Oct 6, 2019
@cowtowncoder cowtowncoder removed the active Issue being actively investigated and/or worked on label Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ZonedDateTime in map keys ignores option to write Zone IDs
3 participants