-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes 127 - ZonedDateTime in map keys can now be serialized with zone IDs #140
Fixes 127 - ZonedDateTime in map keys can now be serialized with zone IDs #140
Conversation
.../src/main/java/com/fasterxml/jackson/datatype/jsr310/ser/key/ZonedDateTimeKeySerializer.java
Outdated
Show resolved
Hide resolved
Tough question on versioning. If we wanted to follow SemVer strictly, I think it should be included in 2.11 as there is behavioral change that might not be considered a bug (or it could be, hence ambiguity). So: @kupci what do you think? I think I am ok with either 2.10.x or 2.11. |
So: I think patch itself is fine. And the only process thing here is that unless I have already asked and received CLA: /~https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf that would be needed now (just once; no need to file for more contributions) Thank you @vetler (Kiitos!) for the contribution; looking forward to merging it once we figure out right branch. |
Given this requires the
|
Ok, then we'll go with 2.10. |
Where do I send it? |
Build failure seems unrelated to changes? |
Yes, seems unrelated to changes. I wonder if there are still Sonatype issues, as this looks like the same error as previously with the 2.10 release. There's a ticket with Sonatype opened already.
|
And here's where to send the CLA (copying from another PR):
|
Sonatype fixed the problem with
@vetler yes, send to |
CLA received, proceed with merging. |
Fixes #127 - ZonedDateTime in map keys can now be serialized with zone IDs