Fix failing tests #650
Merged
Fix failing tests #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cowtowncoder
reviewed
Nov 7, 2020
src/test/java/com/fasterxml/jackson/core/filter/BasicParserFilteringTest.java
Outdated
Show resolved
Hide resolved
|
Excellent thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #573 to fix 2 failing tests.
The failing
BasicGeneratorFilteringTestwas just becausemultipleMatchesneeds to be set to true (and was accidentally flipped to false in #573). The test was updated in 6318aee in a way that requires this flag to be true.The failing
BasicParserFilteringTestis the issue I described here (which appears to have existed since the filtering functionality was introduced). I filed #649 and ignored the test for now.While I was in there, I also extended
BasicParserFilteringTest#testValueOmitsFieldName2slightly to make the input more complex