Graph visualisation would only work if CUDASimulation was explicitly init() #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thinking about this, technically it's possible for a user to activate a visualisation after the simulation has been init, e.g. if manually stepping the model. So that call should also be updated to hook if the sim has been init I guess. Edit: With further changes this should now be addressed, quickly tested it in davids example model by calling |
…licitly init() It should now work if the simulation is not explicitly init, or is init before the visualiser is created.
… provided. On Windows (under visual studio) if a std::filesystem::path contains ':', extension() returns empty string. There's not an obvious method within std::filesystem to check a path for bad characters.
Robadob
force-pushed
the
bugfix_2024_10_26
branch
from
e07ebce to
055e348
Compare
ptheywood
approved these changes
Oct 28, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
applyConfig_derived()is not implicitly called, I assumed otherwise. Hence,CUDAEnvironmentDirectedGraphBufferswas not receiving it's ptr to the visualisation.Also noticed an edge-case with invalid characters in filepaths on Windows so improved the exception thrown.