Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean out some sync behavior in nodal grad #1359

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Clean out some sync behavior in nodal grad #1359

wants to merge 1 commit into from

Conversation

rcknaus
Copy link
Contributor

@rcknaus rcknaus commented Feb 26, 2025

Just need to set on device that grad phi is zero before summing into the field

wjhorne
wjhorne approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@wjhorne wjhorne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Are there are any other spots that come to mind where we are erroneously filling out values on host like this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marchdf marchdf marchdf approved these changes

@wjhorne wjhorne wjhorne approved these changes

@sseraj sseraj Awaiting requested review from sseraj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rcknaus @marchdf @wjhorne