Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add custom url schemes for Bowser #32

Merged
merged 2 commits into from
Mar 8, 2015
Merged

add custom url schemes for Bowser #32

merged 2 commits into from
Mar 8, 2015

Conversation

paericksen
Copy link
Contributor

resolves issue #26

added custom url schemes bowser:// for http and bowsers:// for https

stefanalund
stefanalund reviewed Feb 7, 2015
View reviewed changes
bowser-ios/Bowser.xcodeproj/project.pbxproj
@@ -4024,6 +4024,11 @@
CLASSPREFIX = Bowser;
LastUpgradeCheck = 0600;
ORGANIZATIONNAME = "Ericsson Research";
TargetAttributes = {
B7E3D0D015625681003DE0F1 = {
DevelopmentTeam = 8J7L2VBRVP;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is your iOS Dev team ID. Please select "None" before pushing the code.

@stefanalund
Copy link
Contributor

Nice work, just some minor style fixes and then it's ready to merge.

@stefanalund
Copy link
Contributor

You need to rebase this before I can land it.

@stefanalund
Copy link
Contributor

@paericksen do you mind rebasing this to latest master so that I can land it? Thanks.

@paericksen
Copy link
Contributor Author

rebase failed due to merge conflicts, I'll work on resolving the conflicts when I have a few spare minutes (hopefully this week).

@stefanalund
Copy link
Contributor

OK thanks. Should probably not be a big problem since not much has changed.

stefanalund added a commit that referenced this pull request Mar 8, 2015
@stefanalund
Merge pull request #32 from paericksen/custom_url_branch
2a951ef 
add custom url schemes for Bowser
@stefanalund stefanalund merged commit 2a951ef into EricssonResearch:master Mar 8, 2015
@stefanalund stefanalund mentioned this pull request Mar 8, 2015
Closed
@HBIOSDev
Copy link

HBIOSDev commented May 1, 2015

Is this change uploaded to App Store version of Bowser ?
I have checked appstore version and it is not working.
I tried bowser://www.xyzsite.com but this didnt worked.
If that is not uploaded, when this feature is going to get live ?

@superdump
Copy link
Contributor

We'll be making a new submission to the App Store soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paericksen @stefanalund @HBIOSDev @superdump