Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix async issue where same port is considered open #262

Merged
merged 3 commits into from
Jul 26, 2019

Conversation

netpoetica
Copy link

Solves #261

@asandersSAP
Copy link

Hey guys!

When this will be merged?

@robertmuehsig
Copy link
Collaborator

Good to merge @GregorBiswanger? Looks good to me.

@rakista112
Copy link

Good evening, how may I use this in my project? We need this fix ASAP.

@netpoetica
Copy link
Author

Until this is merged, you will need to use .net/nuget locals. You will need to use my fork of Electron.NET, in your local project. What I do right now is, I have a git repo which contains my fork of Electron.NET as a submodule, and then contains a .sln file alongside my fork of Electron.NET - then I use nuget locals, and a Makefile that helps to make sure I am compiling my fork w/ these changes. (Note: you may want to merge my fork on your local with most recent master, there likely have been changes since I made this PR)

My Directory structure:

~/workspace/my-project -> ls 
.gitmodules
Electron.NET/
Makefile
NuGet.config
my-project.sln

NuGet config for local packages:

~/workspace/my-project -> cat NuGet.config 
<?xml version="1.0" encoding="utf-8"?>
<configuration>
<packageSources>
    <clear />
    <add key="LocalDev" value="./Electron.NET/artifacts" />
    <add key="nuget.org" value="https://api.nuget.org/v3/index.json" protocolVersion="3" />
</packageSources>
</configuration>

Makefile:

~/workspace/my-project-> cat Makefile 

# initialize application
init:
	git submodule init
	dotnet restore

build: clean
	# need to build to get updated opt/Host in my-project
	cd Electron.NET && ./buildReleaseNuGetPackages.sh
	dotnet build

# build for release (osx only)
# application will live at .bin/desktop
release: build
	cd my-project && electronize build /target osx

# run the application
start:
	cd my-project && ASPNETCORE_ENVIRONMENT=development electronize start

# run the application without dev mode
start-production:
	cd my-project && electronize start

clean:
	dotnet nuget locals all --clear
	dotnet restore
	dotnet clean

@rakista112 hope this helps

@netpoetica
Copy link
Author

@GregorBiswanger I assure you, this should be merged :) I promise the JS force is strong with me ^-^

This is going to keep coming up in Electron.NET. I wouldn't be surprised if there are many people experiencing this problem and not commenting about it, but just giving up on Electron.NET because of inconsistent intermittent startup behavior.

@GregorBiswanger GregorBiswanger merged commit ccf0a4c into ElectronNET:master Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants