-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement no_std support #1
Conversation
Unfortunately, some functionality from `core` had to be vendored, because it is not exposed on stable. Hopefully this functionality will be in the `num_traits` crate version 0.2. This would allow deleting the newly added traits.
Thank you so much! This is a really good improvement! Are you using my project for something!? The code is BSD because it is derived from previous work that is BSD. If I re-license under MPL/Apache do I need to get permission from the persons I derived it from? Does this compile on rust 1.0.0? If not what is the oldest version this works on? I rashly decided in my readme that changing minimum rust version is a breaking change. Which may be worth doing, but does require some care. |
Not yet, but I might in the future. :) I want to have some way to do numerical integration on crates.io, so I'm interested in your crate. (I'll probably work on bindings or a port for cuba to have something for multidimensional integration.)
I'm not so sure myself. This blog post seems to suggest that it is possible to relicense BSD code as MPL/Apache (but not the other way around).
Unfortunately not, the minimum version required by num-traits is 1.8. I'll see whether I can get rid of the dependency. |
Removing the |
So I have re-licensed the project. Overall this looks go to me. The nits left:
|
Conflicts: Cargo.toml
See rust-num/num-traits#32 for the related PR. |
Looks good so far, appveyor needs to be updated then I am good to merge. |
Thank you again! |
core
had to be vendored, because it is not exposed by stable Rust. Hopefully this functionality will be in thenum_traits
crate version 0.2. This would allow deleting the newly added traits.BasicFloat
could be implemented in a separate crate with a separate license, or we just wait until its functionality is provided bynum_traits
.