Fix Full Grid Mode Scroll Window bug (adempiere#1285)

EdwinBetanc0urt · Aug 12, 2023 · 680cfd4 · 680cfd4
1 parent 9b4fc3d
commit 680cfd4
Show file tree

Hide file tree

Showing 5 changed files with 60 additions and 10 deletions.
diff --git a/src/views/ADempiere/Window/DocumentWindow.vue b/src/views/ADempiere/Window/DocumentWindow.vue
@@ -32,7 +32,7 @@
         :tabs-list="windowMetadata.tabsListParent"
         :all-tabs-list="allTabsList"
         :actions-manager="actionsManager"
-        style="min-height: 84vh !important;"
+        :style="styleScroll"
       />
       <modal-dialog
         v-if="!isEmptyValue(processUuid)"
@@ -222,6 +222,15 @@ export default defineComponent({
       return isEmptyValue(record) ? action : record
     })
 
+    const showFullGridMode = computed(() => {
+      return store.getters['settings/getFullGridMode']
+    })
+
+    const styleScroll = computed(() => {
+      if (showFullGridMode.value) return 'overflow: auto;'
+      return 'min-height: 84vh !important;'
+    })
+
     /**
      * Watch
      */
@@ -255,7 +264,8 @@ export default defineComponent({
       isViewFullScreenChild,
       isViewFullScreenParent,
       sizeTab,
-      sizeTabChild
+      sizeTabChild,
+      styleScroll
     }
   }
 

diff --git a/src/views/ADempiere/Window/Finances.vue b/src/views/ADempiere/Window/Finances.vue
@@ -33,7 +33,7 @@
         :tabs-list="windowMetadata.tabsListParent"
         :all-tabs-list="allTabsList"
         :actions-manager="actionsManager"
-        style="min-height: 84vh !important;"
+        :style="styleScroll"
       />
       <modal-dialog
         v-if="!isEmptyValue(processUuid)"
@@ -209,6 +209,15 @@ export default defineComponent({
       return props.windowMetadata.currentTab.isParentTab && props.windowMetadata.currentTab.isShowedTableRecords
     })
 
+    const showFullGridMode = computed(() => {
+      return store.getters['settings/getFullGridMode']
+    })
+
+    const styleScroll = computed(() => {
+      if (showFullGridMode.value) return 'overflow: auto;'
+      return 'min-height: 84vh !important;'
+    })
+
     /**
      * Watch
      */
@@ -246,7 +255,8 @@ export default defineComponent({
       sizeTab,
       sizeTabChild,
       actionsManager,
-      isFullGrid
+      isFullGrid,
+      styleScroll
     }
   }
 

diff --git a/src/views/ADempiere/Window/GeneralLedger.vue b/src/views/ADempiere/Window/GeneralLedger.vue
@@ -33,7 +33,7 @@
         :tabs-list="windowMetadata.tabsListParent"
         :all-tabs-list="allTabsList"
         :actions-manager="actionsManager"
-        style="min-height: 84vh !important;"
+        :style="styleScroll"
       />
       <modal-dialog
         v-if="!isEmptyValue(processUuid)"
@@ -209,6 +209,15 @@ export default defineComponent({
       return props.windowMetadata.currentTab.isParentTab && props.windowMetadata.currentTab.isShowedTableRecords
     })
 
+    const showFullGridMode = computed(() => {
+      return store.getters['settings/getFullGridMode']
+    })
+
+    const styleScroll = computed(() => {
+      if (showFullGridMode.value) return 'overflow: auto;'
+      return 'min-height: 84vh !important;'
+    })
+
     /**
      * Watch
      */
@@ -246,7 +255,8 @@ export default defineComponent({
       sizeTab,
       sizeTabChild,
       actionsManager,
-      isFullGrid
+      isFullGrid,
+      styleScroll
     }
   }
 

diff --git a/src/views/ADempiere/Window/MaterialsManagement.vue b/src/views/ADempiere/Window/MaterialsManagement.vue
@@ -33,7 +33,7 @@
         :tabs-list="windowMetadata.tabsListParent"
         :all-tabs-list="allTabsList"
         :actions-manager="actionsManager"
-        style="min-height: 84vh !important;"
+        :style="styleScroll"
       />
       <modal-dialog
         v-if="!isEmptyValue(processUuid)"
@@ -212,6 +212,15 @@ export default defineComponent({
       return props.windowMetadata.currentTab.isParentTab && props.windowMetadata.currentTab.isShowedTableRecords
     })
 
+    const showFullGridMode = computed(() => {
+      return store.getters['settings/getFullGridMode']
+    })
+
+    const styleScroll = computed(() => {
+      if (showFullGridMode.value) return 'overflow: auto;'
+      return 'min-height: 84vh !important;'
+    })
+
     /**
      * Watch
      */
@@ -248,7 +257,8 @@ export default defineComponent({
       sizeTab,
       sizeTabChild,
       actionsManager,
-      isFullGrid
+      isFullGrid,
+      styleScroll
     }
   }
 

diff --git a/src/views/ADempiere/Window/MultiTabWindow.vue b/src/views/ADempiere/Window/MultiTabWindow.vue
@@ -33,7 +33,7 @@
         :tabs-list="windowMetadata.tabsListParent"
         :all-tabs-list="allTabsList"
         :actions-manager="actionsManager"
-        style="min-height: 84vh !important;"
+        :style="styleScroll"
       />
 
       <modal-dialog
@@ -214,6 +214,15 @@ export default defineComponent({
       return props.windowMetadata.currentTab.isParentTab && props.windowMetadata.currentTab.isShowedTableRecords
     })
 
+    const showFullGridMode = computed(() => {
+      return store.getters['settings/getFullGridMode']
+    })
+
+    const styleScroll = computed(() => {
+      if (showFullGridMode.value) return 'overflow: auto;'
+      return 'min-height: 84vh !important;'
+    })
+
     /**
      * Watch
      */
@@ -251,7 +260,8 @@ export default defineComponent({
       sizeTab,
       sizeTabChild,
       actionsManager,
-      isFullGrid
+      isFullGrid,
+      styleScroll
     }
   }