Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[G2M] upgrade storybook and other dev dependencies; also upgraded react-dates #44

Merged
merged 8 commits into from
Apr 3, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .storybook/webpack.config.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
module.exports = function (baseConfig, env, defaultConfig) {
defaultConfig.module.rules.push({
module.exports = ({ config }) => {
config.module.rules.push({
test: /\.stories\.jsx?$/,
loaders: [require.resolve('@storybook/addon-storysource/loader')],
enforce: 'pre',
});
})

return defaultConfig;
};
return config
}
3 changes: 3 additions & 0 deletions CHANGELOG
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed
- `DataTable` Render No columns selected as the placeholder message with empty dataset.

### Changed
- *[Breaking Change]* `peerDependencies` updated with React `^16.8` for utilization of hooks.

## [2.3.2] - 2019-03-15
### Fixed
- `DataTable` crashing bug with empty dataset. (/~https://github.com/EQWorks/extended-semantic-components/issues/37)
Expand Down
9 changes: 3 additions & 6 deletions __tests__/behavior/__snapshots__/data-table.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ exports[`DataTable should render 1`] = `
className="field"
>
<div
className="ui medium icon input"
className="ui icon input"
>
<input
onChange={[Function]}
Expand All @@ -48,6 +48,7 @@ exports[`DataTable should render 1`] = `
<i
aria-hidden="true"
className="search icon"
onClick={[Function]}
/>
</div>
</div>
Expand All @@ -58,40 +59,36 @@ exports[`DataTable should render 1`] = `
<button
className="ui primary button"
onClick={[Function]}
role="button"
>
name
</button>
<button
className="ui primary button"
onClick={[Function]}
role="button"
>
origin
</button>
<button
className="ui primary button"
onClick={[Function]}
role="button"
>
dob
</button>
<button
className="ui primary button"
onClick={[Function]}
role="button"
>
fearsomeness
</button>
</div>
<button
className="ui blue mini icon right floated button"
onClick={[Function]}
role="button"
>
<i
aria-hidden="true"
className="download icon"
onClick={[Function]}
/>
</button>
</div>
Expand Down
36 changes: 18 additions & 18 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@eqworks/extended-semantic-components",
"version": "2.3.2",
"version": "3.0.0-alpha.1",
"description": "A collection of custom Semantic UI React components",
"repository": {
"type": "git",
Expand Down Expand Up @@ -33,7 +33,7 @@
"moment": "^2.23.0",
"numeral": "^2.0.6",
"prop-types": "^15.6.2",
"react-dates": "^19",
"react-dates": "^20.1.0",
"react-dropzone": "^10.0.4",
"react-moment-proptypes": "^1.6.0",
"styled-components": "^4.1.3"
Expand All @@ -59,32 +59,32 @@
"@babel/plugin-syntax-import-meta": "^7.0.0",
"@babel/preset-env": "^7.0.0",
"@babel/preset-react": "^7.0.0",
"@storybook/addon-actions": "^4.1.7",
"@storybook/addon-info": "^4.1.7",
"@storybook/addon-links": "^4.1.7",
"@storybook/addon-storysource": "^4.1.11",
"@storybook/addons": "^4.1.7",
"@storybook/react": "^4.1.7",
"@storybook/addon-actions": "^5.0.3",
"@storybook/addon-info": "^5.0.3",
"@storybook/addon-links": "^5.0.3",
"@storybook/addon-storysource": "^5.0.3",
"@storybook/addons": "^5.0.3",
"@storybook/react": "^5.0.3",
"@storybook/storybook-deployer": "^2.8.1",
"babel-core": "^7.0.0-bridge.0",
"babel-eslint": "^9.0.0",
"babel-jest": "^24.1.0",
"babel-eslint": "^10.0.1",
"babel-jest": "^24.5.0",
"babel-loader": "^8.0.0",
"eslint": "^4.19.1",
"eslint": "^5.15.3",
"eslint-plugin-react": "^7.10.0",
"eslint-watch": "^4.0.2",
"eslint-watch": "^5.0.1",
"fuse.js": "^3.4.4",
"jest": "^24.1.0",
"jest": "^24.5.0",
"react": "^16.8.4",
"react-dom": "^16.7.0",
"react-dom": "^16.8.4",
"react-test-renderer": "^16.8.4",
"rimraf": "^2.6.3",
"semantic-ui-css": "^2.4.1",
"semantic-ui-react": "^0.83.0"
"semantic-ui-react": "^0.86.0"
},
"peerDependencies": {
"react": "^16.7.0",
"react-dom": "^16.7.0",
"semantic-ui-react": "^0.83.0"
"react": "^16.8",
"react-dom": "^16.8",
"semantic-ui-react": "^0.86.0"
}
}
1 change: 0 additions & 1 deletion src/data-table/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,6 @@ class DataTable extends Component {
placeholder='Search...'
value={searchInput}
onChange={this.onSearchInputChange}
size='medium'
icon='search'
/>
)}
Expand Down
Loading