Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i#2154 Android64: Fix compile error #7237

Merged
merged 2 commits into from
Jan 31, 2025
Merged

i#2154 Android64: Fix compile error #7237

merged 2 commits into from
Jan 31, 2025

Conversation

jackgallagher-arm
Copy link
Collaborator

Fixes a compile error for Android64 introduced by #7202 (commit 2f2614b):

core/arch/aarch64/asm_offsetsx.h:85:1: error: offsetof of incomplete type 'struct tlsdesc_t'
   85 | OFFSET(struct tlsdesc_t, arg, 8)
      | ^      ~~~~~~

tlsdesc_t is not defined on Android.

Issues: #2154, #7226

@jackgallagher-arm
i#2154 Android64: Fix compile error
27f2474 
Fixes a compile error for Android64 introduced by #7202
(commit 2f2614b):
```
core/arch/aarch64/asm_offsetsx.h:85:1: error: offsetof of incomplete type 'struct tlsdesc_t'
   85 | OFFSET(struct tlsdesc_t, arg, 8)
      | ^      ~~~~~~
```

`tlsdesc_t` is not defined on Android.

Issues: #2154, #7226
@jackgallagher-arm jackgallagher-arm merged commit f016b8f into master Jan 31, 2025
17 checks passed
@jackgallagher-arm jackgallagher-arm deleted the i2154-android64-fix-asm_offsetsx branch January 31, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egrimley-arm egrimley-arm egrimley-arm approved these changes

@derekbruening derekbruening Awaiting requested review from derekbruening

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackgallagher-arm @egrimley-arm