-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(contract-line): created new endpoint paginated with limit and page #33222
base: develop
Are you sure you want to change the base?
feat(contract-line): created new endpoint paginated with limit and page #33222
Conversation
* | ||
* @return array | ||
*/ | ||
public function getLinesPaginated($id, $limit = 10, $page = 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In doc coment, you must add the type of var, for example:
@param int $id Id of contract
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected
Instead of a adding a new url endpoint, can you instead follow the same solution used for other api than need pagination: Return old format when pagination_data is not set and return with pagination information when set. See example into api that Get a list of orders. We should use the same way for api to get lines. |
NEW|New endpoint paginated with limit and page
I've been added a new endpoint paginated for contract lines