-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zero could be a value #32616
base: 18.0
Are you sure you want to change the base?
zero could be a value #32616
Conversation
@rycks maybe the unique key for the field |
@hregis No ... that is really a test : now i have to find the reason why zero is prohibited and why some dictionnaries use that number :-) |
@hregis ok but tinyint could store (int)0 as a value ... no ? i dig into commit history, here is the origin of the test: 20 years before :-) thanks to comments we could understand that race condition : zero and '' could not be desactivated entries ... that's not really what nowdays code do (without comment i can't imagine the real target of that code in current version) ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with this fix.
@rycks
Have you something else to add for the error message when you update the dictionary line with "0" as code ?
fix #32615 (i hope) :-)
there is a race condition with zero because empty(0) is true ... then we did not display the value