Merge pull request #963 from DeluxeAlonso/feature/code-cleanup

Feature/code cleanup
DeluxeAlonso · Aug 27, 2024 · 2d8ab39 · 2d8ab39
2 parents d03f627 + 2a2593d
commit 2d8ab39
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 1 deletion.
diff --git a/UpcomingMovies/Scenes/Movies/MovieDetail/MovieDetailProtocols.swift b/UpcomingMovies/Scenes/Movies/MovieDetail/MovieDetailProtocols.swift
@@ -18,6 +18,7 @@ protocol MovieDetailViewModelProtocol {
 
     var screenTitle: String { get }
     var shareTitle: String { get }
+    var cancelTitle: String { get }
 
     var startLoading: AnyBehaviorBindable<Bool> { get }
     var showGenreName: AnyBehaviorBindable<String> { get }

diff --git a/UpcomingMovies/Scenes/Movies/MovieDetail/MovieDetailViewController.swift b/UpcomingMovies/Scenes/Movies/MovieDetail/MovieDetailViewController.swift
@@ -196,7 +196,7 @@ final class MovieDetailViewController: UIViewController, Storyboarded, Transitio
         let availableActions = actionModels.map { actionModel in
             UIAlertAction(title: actionModel.title, style: .default) { _ in actionModel.action() }
         }
-        let cancelAction = UIAlertAction(title: LocalizedStrings.cancel(), style: .cancel) { _ in
+        let cancelAction = UIAlertAction(title: viewModel?.cancelTitle, style: .cancel) { _ in
             self.dismiss(animated: true)
         }
         let actions = [cancelAction] + availableActions

diff --git a/UpcomingMovies/Scenes/Movies/MovieDetail/MovieDetailViewModel.swift b/UpcomingMovies/Scenes/Movies/MovieDetail/MovieDetailViewModel.swift
@@ -57,6 +57,10 @@ final class MovieDetailViewModel: MovieDetailViewModelProtocol {
         String(format: LocalizedStrings.movieDetailShareText(), title)
     }
 
+    var cancelTitle: String {
+        LocalizedStrings.cancel()
+    }
+
     // MARK: - Initializers
 
     init(_ movie: MovieProtocol,

diff --git a/UpcomingMoviesTests/Movies/MovieDetail/MovieDetailViewModelTests.swift b/UpcomingMoviesTests/Movies/MovieDetail/MovieDetailViewModelTests.swift
@@ -122,6 +122,15 @@ final class MovieDetailViewModelTests: XCTestCase {
         XCTAssertEqual(screenTitle, String(format: LocalizedStrings.movieDetailShareText(), titleToTest))
     }
 
+    func testCancelTitle() {
+        // Arrange
+        let viewModelToTest = createSUT(with: MockMovieProtocol())
+        // Act
+        let cancelTitle = viewModelToTest.cancelTitle
+        // Assert
+        XCTAssertEqual(cancelTitle, "Cancel")
+    }
+
     func testSaveVisitedMovie() {
         // Arrange
         let viewModelToTest = createSUT(with: 1, title: "Title")