Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added unit tests and examples #9

Merged
merged 17 commits into from
Feb 25, 2025
Merged

Added unit tests and examples #9

merged 17 commits into from
Feb 25, 2025

Conversation

panosatha
Copy link
Collaborator

@panosatha panosatha commented Feb 13, 2025 •
edited
Loading

This includes the use of a meteo dataset factory in the init.

@panosatha panosatha changed the title Added unit tests and corrected small bugs Added unit tests and examples Feb 14, 2025
@panosatha panosatha requested a review from LuukBlom February 14, 2025 14:05
LuukBlom
LuukBlom previously approved these changes Feb 14, 2025
View reviewed changes
Copy link
Collaborator

@LuukBlom LuukBlom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

We could discuss adding mocking to separate testing the logic from testing the API download calls. But tbh, I like how you've set it up, and mocking will introduce more complexity and take more time to write and maintain as well.

Nice work!

@LuukBlom LuukBlom mentioned this pull request Feb 21, 2025
Open
@panosatha panosatha merged commit 05de90f into main Feb 25, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuukBlom LuukBlom LuukBlom left review comments

@maartenvanormondt maartenvanormondt Awaiting requested review from maartenvanormondt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@panosatha @LuukBlom @maartenvanormondt