Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-8600: Add instrumented test module for kotlin compiler plugin #315

Merged

Conversation

ambushwork
Copy link
Member

@ambushwork ambushwork commented Feb 18, 2025

What does this PR do?

Add a dedicated module instrumented in the project with compose dependency, in order to test kotlin compiler plugin with android instrumental environment.

Currently only a simple screen and single test is added.

Motivation

RUM-8600

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.88%. Comparing base (0ea7233) to head (e691352).
Report is 2 commits behind head on feature/kotlin-compiler-plugin.

Additional details and impacted files
@@                        Coverage Diff                        @@
##             feature/kotlin-compiler-plugin     #315   +/-   ##
=================================================================
  Coverage                             76.88%   76.88%           
+ Complexity                              259      258    -1     
=================================================================
  Files                                    34       34           
  Lines                                   956      956           
  Branches                                113      113           
=================================================================
  Hits                                    735      735           
  Misses                                  165      165           
  Partials                                 56       56           

see 2 files with indirect coverage changes

@ambushwork ambushwork marked this pull request as ready for review February 18, 2025 14:25
@ambushwork ambushwork requested review from a team as code owners February 18, 2025 14:25
satween
satween previously approved these changes Feb 19, 2025
@ambushwork ambushwork dismissed stale reviews from jonathanmos and satween via 271afd5 February 20, 2025 10:49
@ambushwork ambushwork force-pushed the yl/kcp/add-instrumented-module branch from 8ff0e73 to 271afd5 Compare February 20, 2025 10:49
xgouchet
xgouchet previously approved these changes Feb 24, 2025
jonathanmos
jonathanmos previously approved these changes Feb 24, 2025
xgouchet
xgouchet previously approved these changes Feb 25, 2025
@ambushwork ambushwork force-pushed the yl/kcp/add-instrumented-module branch from 296b3be to 376285d Compare February 26, 2025 15:19
0xnm
0xnm previously approved these changes Feb 27, 2025
Copy link
Member

@0xnm 0xnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments, but nothing blocking.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably not needed, since it is empty?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AndroidManifest needs to be kept even though it is null, otherwise it won't compile

@ambushwork ambushwork dismissed stale reviews from 0xnm, xgouchet, and jonathanmos via 2b44ce4 February 27, 2025 12:10
@ambushwork ambushwork force-pushed the yl/kcp/add-instrumented-module branch from 376285d to 2b44ce4 Compare February 27, 2025 12:10
0xnm
0xnm previously approved these changes Feb 27, 2025
@ambushwork ambushwork merged commit 33b3236 into feature/kotlin-compiler-plugin Feb 27, 2025
13 checks passed
@ambushwork ambushwork deleted the yl/kcp/add-instrumented-module branch February 27, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants