-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUM-8600: Add instrumented test module for kotlin compiler plugin #315
RUM-8600: Add instrumented test module for kotlin compiler plugin #315
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/kotlin-compiler-plugin #315 +/- ##
=================================================================
Coverage 76.88% 76.88%
+ Complexity 259 258 -1
=================================================================
Files 34 34
Lines 956 956
Branches 113 113
=================================================================
Hits 735 735
Misses 165 165
Partials 56 56 |
instrumented/src/androidTest/java/com/datadog/android/instrumented/SemanticsTest.kt
Outdated
Show resolved
Hide resolved
instrumented/src/androidTest/java/com/datadog/android/instrumented/SemanticsTest.kt
Outdated
Show resolved
Hide resolved
8ff0e73
to
271afd5
Compare
271afd5
to
296b3be
Compare
296b3be
to
376285d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments, but nothing blocking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably not needed, since it is empty?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AndroidManifest needs to be kept even though it is null, otherwise it won't compile
2b44ce4
376285d
to
2b44ce4
Compare
2b44ce4
to
e691352
Compare
What does this PR do?
Add a dedicated module
instrumented
in the project with compose dependency, in order to test kotlin compiler plugin with android instrumental environment.Currently only a simple screen and single test is added.
Motivation
RUM-8600
Review checklist (to be filled by reviewers)