chore: Update CMAKE to 3.22.1 for gitlab builds. #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #221 +/- ##
=============================================
+ Coverage 78.05% 78.20% +0.15%
- Complexity 186 187 +1
=============================================
Files 22 22
Lines 665 665
Branches 85 85
=============================================
+ Hits 519 520 +1
Misses 116 116
+ Partials 30 29 -1 |
0xnm
previously approved these changes
Feb 12, 2024
| @@ -29,7 +29,7 @@ ENV ANDROID_COMPILE_SDK 34 | |||
| ENV ANDROID_BUILD_TOOLS 34.0.0 | |||
| ENV ANDROID_SDK_TOOLS 10406996 | |||
| ENV NDK_VERSION 21.3.6528147 | |||
| ENV CMAKE_VERSION 3.10.2.4988404 | |||
| ENV CMAKE_VERSION 3.22.1 | |||
There was a problem hiding this comment.
you probably want also to bump image version in .gitlab-ci.yml, so that it is deployed and used.
There was a problem hiding this comment.
Is that just changing this line from 6 to 7? Do I have to do anything else?
There was a problem hiding this comment.
yes, you need to change this line and then run image generation job (ci-image) manually
fuzzybinary
force-pushed
the
jward/cmake-update
branch
from
8c2a5a3 to
5bc4c97
Compare
0xnm
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Some plugin builds are failing because we're missing CMAKE 3.22.1. Update the Dockerfile so that CMAKE 3.22.1 is always installed.
Review checklist (to be filled by reviewers)