Ds 193/experiment footer #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybooks Link For Branch |
Caterina-vanHerpt
suggested changes
Nov 17, 2021
|
This pull request introduces 1 alert when merging 71c0f51 into efef617 - view on LGTM.com new alerts:
|
Caterina-vanHerpt
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Reviewer: @Caterina-vanHerpt
Description & Background Context:
Example Footer component based on https://design.canada.ca/common-design-patterns/site-footer.html designs and requirements
Where should the reviewer start?
File name: footer.js, footer.test.js, footer.stories.js
How should this be tested?
The reviewer will need to pull the branch onto their local machine and run test the component through storybook
To test the footer with and without it's optional elements, run storybook and toggle the isOptional field from "true" to "false" on storybook or change the isOptional parameter directly in the code as specified below:
line 71, Footer.stories.js, change true to false
Are there any breaking changes?
No