migrate scripts to new persistence API #934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on DFHack/dfhack#4153
most scripts had a straightforward conversion
once-per-save was doing a lot of undocumented stuff that is no longer necessary, so it got largely rewritten
made persistence in
prioritizemore efficient by not confusing the json serializer with a map that looks like a sparse listchanged persistence format of
devel/prepare-save, but the persistence appears to be for human readability and is not read by the scriptwarn-stranded had a format change and will lose history. the persistence key name was changed so that old data won't mess up the new formats. this is only the list of stranded units that you are ignoring, though, so the impact to players is low. I wish I had caught the non-standard persistence format in code review : /