Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Syntax warning #210

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Conversation

henrikstranneheim
Copy link
Contributor

@henrikstranneheim henrikstranneheim commented Sep 25, 2024

Description

Added

Changed

Fixed

Testing

How to prepare for test

  • ssh to Hasta
  • Test your branch with
housekeeper-test-deploy fix-python-syntax-warning
housekeeper-test get bundle justhusky

Any migrations need to be applied manually with alembic against the stage database.

How to test

  • login to ...
  • do ...

Expected test outcome

  • check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • code approved by
  • tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@henrikstranneheim henrikstranneheim self-assigned this Sep 25, 2024
@henrikstranneheim henrikstranneheim requested a review from a team as a code owner September 25, 2024 07:21
@henrikstranneheim henrikstranneheim linked an issue Sep 25, 2024 that may be closed by this pull request
@henrikstranneheim
Copy link
Contributor Author

Removed Syntaxwarning, 👍

enrik.stranneheim@hasta:~] [base] $ housekeeper-test get bundle justhusky
INFO:    Converting OCI blobs to SIF format
INFO:    Starting build...
Getting image source signatures
Skipping fetch of repeat blob sha256:6533c3eba3f3cd4c840877f9245b26929fc8c22a39f42c872aa314c32c6d654b
Skipping fetch of repeat blob sha256:6671afbf80d520b90e6bc20b00bf42d8c8b9b03f37e60a0bdb47ee01564df8b7
Skipping fetch of repeat blob sha256:035d07709dfb5588e1576091d0f994ee2c7ec39e89150803ff8ef975a9034596
Skipping fetch of repeat blob sha256:102a6e7f7a21934a56851632b76315e0c2067b22256a4543c859a1c561bd957b
Skipping fetch of repeat blob sha256:e49ef8976f018af3a4a1ccada0d4f8c2ec51f9d2f07963ee3639f39515352df0
Skipping fetch of repeat blob sha256:707845890a326417b9e14b4285012cd65ee22bb59fc16830291fbfcc494c1899
Skipping fetch of repeat blob sha256:67d2b6235a489b8afa7ffaaa77d0f3fcabaddaee57edf63de84f244e6a2950c6
Copying config sha256:d0589e16af378184e29793d6771308a9a5d7481bff540338a2150da521a7e201
 5.84 KiB / 5.84 KiB [======================================================] 0s
Writing manifest to image destination
Storing signatures
INFO:    Creating SIF file...
INFO:    Build complete: /home/henrik.stranneheim/.singularity/cache/oci-tmp/ff8befeb8401b19656043038269816f66ae2a084f9bca89fdbcc78ade5b43c4d/housekeeper_fix-python-syntax-warning.sif
INFO:    Image cached as SIF at /home/henrik.stranneheim/.singularity/cache/oci-tmp/ff8befeb8401b19656043038269816f66ae2a084f9bca89fdbcc78ade5b43c4d/housekeeper_fix-python-syntax-warning.sif
2024-09-25 09:29:43 hasta.scilifelab.se housekeeper.cli.core[122607] INFO Use root path /home/proj/stage/housekeeper-bundles
                                              📦 Bundle table 📦
┏━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ ID   ┃ Bundle name ┃ Version IDs                                                               ┃ Created    ┃
┡━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ 8925 │ justhusky   │ 191243, 178836, 167748, 140963, 136933, 120104, 51171, 42582, 16939, 9523 │ 2019-06-11 │
└──────┴─────────────┴───────────────────────────────────────────────────────────────────────────┴────────────┘
                               📕 Version table 📕
┏━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━┓
┃ ID     ┃ Bundle name ┃ Nr files ┃ Included   ┃ Archived ┃ Created    ┃ Expires ┃
┡━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━┩
│ 191243 │ justhusky   │ 356      │ 2024-06-25 │          │ 2024-06-24 │         │
└────────┴─────────────┴──────────┴────────────┴──────────┴────────────┴─────────┘
                                                                                                 📜 Local files 📜
┏━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
┃ ID      ┃ File name                                                                                                                                       ┃ Tags                                                ┃
┡━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┩
│ 6273863 │ /home/proj/stage/housekeeper-bundles/justhusky/2024-06-24/earlycasualcaiman_lanes_1_fastp_sorted_md.cram                                        │ earlycasualcaiman, cram, scout                      │
│ 6273864

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

@henrikstranneheim
Copy link
Contributor Author

This fixes the syntaxwarning without changing the regexp, hence no worse than before. The regexp and use of it looks complex to change, but it looks like the Sonarcloud warning is not relevant.

Copy link
Contributor

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@henrikstranneheim henrikstranneheim merged commit c593b9b into master Sep 26, 2024
6 of 7 checks passed
@henrikstranneheim henrikstranneheim deleted the fix-python-syntax-warning branch September 26, 2024 06:20
@henrikstranneheim
Copy link
Contributor Author

Deployed to prod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.12 Syntax warning
2 participants