Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pypi): Action #206

Merged
merged 1 commit into from
Sep 19, 2024
Merged

fix(pypi): Action #206

merged 1 commit into from
Sep 19, 2024

Conversation

henrikstranneheim
Copy link
Contributor

@henrikstranneheim henrikstranneheim commented Sep 18, 2024

Description

Added

Changed

Fixed

Testing

How to prepare for test

  • ssh to Hasta
  • Test your branch with
housekeeper-test-deploy <branch-name>
housekeeper-test <command here>

Any migrations need to be applied manually with alembic against the stage database.

How to test

  • login to ...
  • do ...

Expected test outcome

  • check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • code approved by
  • tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@henrikstranneheim henrikstranneheim requested a review from a team as a code owner September 18, 2024 07:08
Copy link

Copy link

@ahdamin ahdamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@henrikstranneheim henrikstranneheim merged commit 8f68e7c into master Sep 19, 2024
7 checks passed
@henrikstranneheim henrikstranneheim deleted the fix-pypi-build-action branch September 19, 2024 06:05
@henrikstranneheim
Copy link
Contributor Author

Nothing to deploy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants