Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cryptography dependency #312

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Conversation

northwestwitch
Copy link
Member

@northwestwitch northwestwitch commented Jun 5, 2024

Description

Added

  • cryptography lib dependency

How to test

  • Deploy on stage

Expected outcome

  • make sure demo report page works

Review

  • Tests executed by CR
  • "Merge and deploy" approved by

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@northwestwitch northwestwitch changed the title Installing cryptography Added cryptography dependency Jun 5, 2024
Copy link

sonarqubecloud bot commented Jun 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.40%. Comparing base (4c8ac1b) to head (17ef357).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #312   +/-   ##
=======================================
  Coverage   94.40%   94.40%           
=======================================
  Files          35       36    +1     
  Lines        2002     2003    +1     
=======================================
+ Hits         1890     1891    +1     
  Misses        112      112           
Flag Coverage Δ
unittests 94.40% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@northwestwitch
Copy link
Member Author

After deploying on stage, demo report works:

image

@northwestwitch northwestwitch requested a review from ChrOertlin June 5, 2024 12:29
Copy link
Contributor

@henrikstranneheim henrikstranneheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@northwestwitch northwestwitch merged commit b37e121 into main Jun 5, 2024
7 checks passed
@northwestwitch northwestwitch deleted the installing_cryptography branch June 5, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants