-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.1.0 - Timeouts rework, command method #167
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshustov
reviewed
Jun 15, 2023
slvrtrn
commented
Jun 15, 2023
mshustov
reviewed
Jun 20, 2023
slvrtrn
changed the title
0.1.0 - Timeouts rework
0.1.0 - Timeouts rework, command method
Jun 20, 2023
mshustov
reviewed
Jun 20, 2023
mshustov
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
node-abort-controller
dependency is removedinsert
response stream is destroyed immediatelycommand
method is introducedChangelog:
Breaking changes
connect_timeout
client setting is removed, as it was unused in the code.New features
command
method is introduced as an alternative toexec
.command
does not expect user to consume the response stream, and it is destroyed immediately.Essentially, this is a shortcut to
exec
that destroys the stream under the hood.Consider using
command
instead ofexec
for DDLs and other custom commands which do not provide any valuable output.Example:
Bug fixes
insert
that happened due to unclosed stream instance when using low number ofmax_open_connections
. See #161 for more details.Checklist