Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client-v2] Implements conversion from boolean, to boolean. Added tests #1913

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

chernser
Copy link
Contributor

@chernser chernser commented Nov 6, 2024

Summary

Number values can be converted to boolean and visa versa. This PR fixes this and adds proper conversion boolean to numbers.

Closes: #1908

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in /~https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@chernser chernser requested a review from Paultagoras November 6, 2024 21:32
Copy link

sonarqubecloud bot commented Nov 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
18.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@chernser chernser merged commit b08a38f into main Nov 6, 2024
55 of 60 checks passed
@chernser chernser deleted the v2_fix_reading_boolean branch November 6, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[client v2] ClassCastException in AbstractBinaryFormatReader#readNumberValue for Boolean column
2 participants