Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client-v2] Fixes BinaryStreamReader parsing DateTime64 values. Using a column defined scale now. #1863

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

chernser
Copy link
Contributor

@chernser chernser commented Oct 10, 2024

Summary

Added more tests for DateTime values and made it be read with column defined scale.

Closes: #1851

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in /~https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@chernser chernser requested a review from Paultagoras October 10, 2024 13:45
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
40.0% Coverage on New Code (required ≥ 80%)
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@chernser chernser changed the title made datetime64 column to be read with column defined scale [client-v2] Fixes BinaryStreamReader to get parsing of DateTime64 values using column defined scale. Oct 16, 2024
@chernser chernser changed the title [client-v2] Fixes BinaryStreamReader to get parsing of DateTime64 values using column defined scale. [client-v2] Fixes BinaryStreamReader parsing DateTime64 values. Using a column defined scale now. Oct 16, 2024
@chernser chernser merged commit 1704cab into main Oct 17, 2024
57 of 60 checks passed
@chernser chernser deleted the v2_reading_datetime_with_column_scale branch October 17, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[client-v2] BinaryStreamReader does not use column scale for DateTime64
2 participants