Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clang-14 for installing gems with Rust extensions #128

Merged
merged 2 commits into from
May 2, 2023

Conversation

HarlemSquirrel
Copy link
Contributor

Add clang-14 dependency for installing gems with Rust extensions such as /~https://github.com/HarlemSquirrel/tzf-rb

Add clang-14 dependency for installing gems with Rust extensions such as /~https://github.com/HarlemSquirrel/tzf-rb
@HarlemSquirrel HarlemSquirrel requested a review from a team as a code owner April 19, 2023 14:54
@JalexChen
Copy link
Contributor

Hi @HarlemSquirrel,

I've ran this and it looks like it's passing. It looks like the link you're referencing is a personal project. Are there other extensions that would need to include this? Would gcc suffice or is clang a requirement here?

@JalexChen JalexChen self-assigned this May 1, 2023
@HarlemSquirrel
Copy link
Contributor Author

HarlemSquirrel commented May 1, 2023

Hi @HarlemSquirrel,

I've ran this and it looks like it's passing. It looks like the link you're referencing is a personal project. Are there other extensions that would need to include this? Would gcc suffice or is clang a requirement here?

I believe anything using /~https://github.com/oxidize-rb/rb-sys/ would need this. That's the defacto way to build Ruby gems with Rust extensions. This is now a supported feature of RubyGems as of rubygems/rubygems#5175

I'm not sure if gcc would be enough but it should be easy enough to test with gem install tzf

@HarlemSquirrel
Copy link
Contributor Author

@JalexChen It seems gcc is already installed on this image and does not seem to be sufficient.

3.2/Dockerfile Outdated Show resolved Hide resolved
@HarlemSquirrel HarlemSquirrel requested a review from JalexChen May 2, 2023 18:29
@JalexChen JalexChen merged commit 7b15ab7 into CircleCI-Public:main May 2, 2023
@HarlemSquirrel HarlemSquirrel deleted the patch-2 branch May 2, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants