Bug: Age is not correct in Birthday Calendar. #6990

[bigtigerku]

Description & Issue number it closes

Bug: Age is not correct in Birthday Calendar. #6990

Use same date function used in Person::getBirthDate() to create calendar date

Screenshots (if appropriate)

Before

After

How to test the changes?

http://localhost/v2/calendar

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

From local host with

npm run build
num run package
npm run docker-test-start

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[respencer]

I have confirmed the issue, oddly this PR does not fix the issue for me.

Needs further investigation.

[respencer]

Okay, this is more complicated than it first appeared.

On the calendar you want the age they are going to become, in the year of the calendar view (so not now).

On their profile you want the age they currently are, on the day you look at the profile (so now).

It seems to be relying on the same code, but needs different results.

The calendar view needs to subtracts the calendar view year from the date of birth year, e.g.: 2024 - 2012

The profile using date_diff only clocks over at the end of the day, so if the birthday is today it will show the year 1 less than you would expect. So that needs to be tweaked to, but you only want that to happen on the day.

[respencer]

Okay, it looks good to me.

Found a few other bugs, but that's not due to this PR. This one fixes what it says it does.

[respencer]

Looks good to me, and passed my testing.