Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update all deps #6864

Merged
merged 4 commits into from
Feb 14, 2024
Merged

update all deps #6864

merged 4 commits into from
Feb 14, 2024

Conversation

DAcodedBEAT
Copy link
Contributor

Description & Issue number it closes

update all deps, make code slightly less smelly

MrClever
MrClever approved these changes Feb 14, 2024
View reviewed changes
Copy link
Collaborator

@MrClever MrClever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me assuming all the tests pass 👍🏻

@DAcodedBEAT DAcodedBEAT added this to the vNext milestone Feb 14, 2024
@DAcodedBEAT DAcodedBEAT added Code Smell Package Dependencies javascript Pull requests that update Javascript code php Pull requests that update Php code labels Feb 14, 2024
@DAcodedBEAT DAcodedBEAT merged commit ce4502d into master Feb 14, 2024
4 checks passed
@DAcodedBEAT DAcodedBEAT deleted the deps branch February 14, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrClever MrClever MrClever approved these changes

@DawoudIO DawoudIO Awaiting requested review from DawoudIO

Assignees
No one assigned
Labels
Code Smell javascript Pull requests that update Javascript code Package Dependencies php Pull requests that update Php code
Projects
None yet
Milestone
5.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DAcodedBEAT @MrClever