Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only use window scale in children #5833

Merged
merged 2 commits into from
Jan 19, 2025
Merged

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Jan 18, 2025

Bug I introduced in #5794, where the window would call scale(), which would attempt to load scale_ from itself, but that's the variable it wanted to initialize, so now it read garbage and initialized that variable to garbage and then subsequent reads from scale_ would yield that garbage until the window loaded the scale setting.

Not sure if that's the cause of #5831 (I couldn't replicate this1).

Footnotes

  1. Not the exact issue that is. On MSVC, the scale was initialized to a negative value, meaning that calls to setMinimumSize would print an error in Qt.

@pajlada pajlada merged commit b0fee11 into Chatterino:master Jan 19, 2025
18 checks passed
@Nerixyz Nerixyz deleted the fix/buttons branch January 19, 2025 10:51
@2547techno 2547techno mentioned this pull request Jan 20, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants