fix: only use window scale in children #5833
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug I introduced in #5794, where the window would call
scale()
, which would attempt to loadscale_
from itself, but that's the variable it wanted to initialize, so now it read garbage and initialized that variable to garbage and then subsequent reads fromscale_
would yield that garbage until the window loaded the scale setting.Not sure if that's the cause of #5831 (I couldn't replicate this1).
Footnotes
Not the exact issue that is. On MSVC, the scale was initialized to a negative value, meaning that calls to
setMinimumSize
would print an error in Qt. ↩