Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test/once-flag): loosen requirement for tight timing #5733

Merged
merged 2 commits into from
Nov 24, 2024
Merged

fix(test/once-flag): loosen requirement for tight timing #5733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1028dd3
fix: loosen requirement for tight timing
Nerixyz Nov 24, 2024
b0c9d8f
changelog
Nerixyz Nov 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@
- Dev: Unified parsing of historic and live IRC messages. (#5678)
- Dev: 7TV's `entitlement.reset` is now explicitly ignored. (#5685)
- Dev: Qt 6.8 and later now default to the GDI fontengine. (#5710)
- Dev: Moved to condition variables when shutting down worker threads. (#5721)
- Dev: Moved to condition variables when shutting down worker threads. (#5721, #5733)

## 2.5.1

Expand Down
2 changes: 1 addition & 1 deletion tests/src/OnceFlag.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ TEST(OnceFlag, waitFor)
ASSERT_TRUE(stoppedFlag.waitFor(std::chrono::milliseconds{200}));
auto stop = std::chrono::system_clock::now();

ASSERT_LT(stop - start, std::chrono::milliseconds{150});
ASSERT_LT(stop - start, std::chrono::milliseconds{200});

start = std::chrono::system_clock::now();
ASSERT_TRUE(stoppedFlag.waitFor(std::chrono::milliseconds{1000}));
Expand Down
Loading