fix: escape more 7tv things (#5780)

Chatterino · Dec 31, 2024 · becc100 · becc100
1 parent fae3e7a
commit becc100
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@
 
 - Bugfix: Fixed scrollbar highlights being visible in overlay windows. (#5769)
 - Bugfix: Make macos fonts look the same as v2.5.1. (#5775)
+- Bugfix: Fixed 7TV usernames messing with Qt's HTML (#5780)
 - Dev: Hard-code Boost 1.86.0 in macos CI builders. (#5774)
 
 ## 2.5.2-beta.1

diff --git a/src/providers/seventv/SeventvEmotes.cpp b/src/providers/seventv/SeventvEmotes.cpp
@@ -81,7 +81,8 @@ Tooltip createTooltip(const QString &name, const QString &author, bool isGlobal)
     return Tooltip{QString("%1<br>%2 7TV Emote<br>By: %3")
                        .arg(name.toHtmlEscaped(),
                             isGlobal ? "Global" : "Channel",
-                            author.isEmpty() ? "<deleted>" : author)};
+                            author.isEmpty() ? "&lt;deleted&gt;"
+                                             : author.toHtmlEscaped())};
 }
 
 Tooltip createAliasedTooltip(const QString &name, const QString &baseName,
@@ -90,7 +91,8 @@ Tooltip createAliasedTooltip(const QString &name, const QString &baseName,
     return Tooltip{QString("%1<br>Alias of %2<br>%3 7TV Emote<br>By: %4")
                        .arg(name.toHtmlEscaped(), baseName.toHtmlEscaped(),
                             isGlobal ? "Global" : "Channel",
-                            author.isEmpty() ? "<deleted>" : author)};
+                            author.isEmpty() ? "&lt;deleted&gt;"
+                                             : author.toHtmlEscaped())};
 }
 
 CreateEmoteResult createEmote(const QJsonObject &activeEmote,